Make screen.orientation implementation use WebScreenInfo::orientationType

Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 146 matching lines @@
     if (m_view && isMainFrame()) {
         if (settings()->pinchVirtualViewportEnabled())
             m_host->pinchViewport().mainFrameDidChangeSize();
         else
             m_view->setVisibleContentScaleFactor(page()->pageScaleFactor());
     }
 }
 
 void LocalFrame::sendOrientationChangeEvent()
 {
-    if (!RuntimeEnabledFeatures::orientationEventEnabled())
+    if (!RuntimeEnabledFeatures::orientationEventEnabled() && !RuntimeEnabledFeatures::screenOrientationEnabled())
         return;
 
-    if (DOMWindow* window = domWindow())
+    if (DOMWindow* window = domWindow()) {
         window->dispatchEvent(Event::create(EventTypeNames::orientationchange));
+        // Notify subframes.
+        for (RefPtr<LocalFrame> child = tree().firstChild(); child; child = child->tree().nextSibling())
+            child->sendOrientationChangeEvent();

[mlamouri (slow - plz ping), 2014/05/20 20:09:26]

I would prefer having that in Page to prevent the recursion but I'm not an owner
so I will let the owner decide.

[jochen (gone - plz use gerrit), 2014/05/26 10:02:11]

when iterating over the tree and dispatching events, please first copy the tree
to a Vector<RefPtr<LocalFrame> > and then iterate over that as JS might change
the tree structure.

[Inactive, 2014/05/27 14:22:15]

Good point, sorry I missed that. I fixed it.

+    }
 }
 
 void LocalFrame::setPrinting(bool printing, const FloatSize& pageSize, const FloatSize& originalPageSize, float maximumShrinkRatio)
 {
     // In setting printing, we should not validate resources already cached for the document.
     // See https://bugs.webkit.org/show_bug.cgi?id=43704
     ResourceCacheValidationSuppressor validationSuppressor(document()->fetcher());
 
     document()->setPrinting(printing);
     view()->adjustMediaTypeForPrinting(printing);
@@ skipping 459 matching lines @@
 LocalFrame* LocalFrame::localFrameRoot()
 {
     LocalFrame* curFrame = this;
     while (curFrame && curFrame->tree().parent() && curFrame->tree().parent()->isLocalFrame())
         curFrame = curFrame->tree().parent();
 
     return curFrame;
 }
 
 } // namespace WebCore