MD Settings: Don't search inside <dialog> elements.

chrome/browser/resources/settings/search_settings.js

Index: chrome/browser/resources/settings/search_settings.js
diff --git a/chrome/browser/resources/settings/search_settings.js b/chrome/browser/resources/settings/search_settings.js
index 30e03de6daeb4ac55a816529e032b0979a42e3a4..ad541dd43c290f012d82080607789645da34f083 100644
--- a/chrome/browser/resources/settings/search_settings.js
+++ b/chrome/browser/resources/settings/search_settings.js
@@ -44,15 +44,11 @@ cr.define('settings', function() {
   var IGNORED_ELEMENTS = new Set([
     'CONTENT',
     'CR-EVENTS',
+    'DIALOG',
     'IMG',
     'IRON-ICON',
     'IRON-LIST',
     'PAPER-ICON-BUTTON',
-    /* TODO(dpapad): paper-item is used for dynamically populated dropdown
-     * menus. Perhaps a better approach is to mark the entire dropdown menu such
-     * that search algorithm can skip it as a whole instead.
-     */
-    'PAPER-ITEM',

[tommycli, 2017/03/24 19:07:19]

I assume you've determined this is no longer needed? Were you supposed to add a
replacement element?

[dpapad, 2017/03/24 19:13:22]

Yes no longer needed, because we removed all paper-item instances from our code.
There is no replacement either, because paper-item existed inside iron-dropdown
elements to implement action menus. Since then action menus are implemented as
<dialog>s too, and are correctly ignored by (as a result of this change).

     'PAPER-RIPPLE',
     'PAPER-SLIDER',
     'PAPER-SPINNER',