Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2705)

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 2773973002: Add Startup.BrowserView.FirstPaint / .CompositingEnded histograms. (Closed)
Patch Set: WasNonBrowserUIDisplayed --> WasMainWindowStartupInterrupted, combine the tests, report trace with … Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h
index d2172e5a99568b3a15133d6c131f8eb2134b1f07..3fc05b211c8762c00f8ef49f1958c619a86c0fa9 100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -50,6 +50,7 @@
class BookmarkBarView;
class Browser;
+class BrowserViewHistogramHelper;
class BrowserViewLayout;
class ContentsLayoutManager;
class DownloadShelfView;
@@ -438,6 +439,7 @@ class BrowserView : public BrowserWindow,
void OnGestureEvent(ui::GestureEvent* event) override;
void ViewHierarchyChanged(
const ViewHierarchyChangedDetails& details) override;
+ void PaintChildren(const ui::PaintContext& context) override;
void ChildPreferredSizeChanged(View* child) override;
void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
void OnThemeChanged() override;
@@ -714,6 +716,8 @@ class BrowserView : public BrowserWindow,
std::unique_ptr<ExtensionKeybindingRegistryViews>
extension_keybinding_registry_;
+ std::unique_ptr<BrowserViewHistogramHelper> histogram_helper_;
tapted 2017/04/07 00:49:34 Same here - I don't think this needs to be a point
themblsha 2017/04/10 17:28:18 Ok, removed unique_ptr :-)
+
mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
DISALLOW_COPY_AND_ASSIGN(BrowserView);

Powered by Google App Engine
This is Rietveld 408576698