Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8106)

Unified Diff: chrome/browser/metrics/browser_window_histogram_helper.cc

Issue 2773973002: Add Startup.BrowserView.FirstPaint / .CompositingEnded histograms. (Closed)
Patch Set: Fix gab's and asvitkine's remarks. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/browser_window_histogram_helper.cc
diff --git a/chrome/browser/metrics/browser_window_histogram_helper.cc b/chrome/browser/metrics/browser_window_histogram_helper.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ba4c8bcfabb846e3c2e7b2f9d5957078fe3045c4
--- /dev/null
+++ b/chrome/browser/metrics/browser_window_histogram_helper.cc
@@ -0,0 +1,58 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/metrics/browser_window_histogram_helper.h"
+
+#include "components/startup_metric_utils/browser/startup_metric_utils.h"
+#include "ui/compositor/compositor.h"
+
+BrowserWindowHistogramHelper::BrowserWindowHistogramHelper(
+ ui::Compositor* compositor)
+ : scoped_observer_(this) {
+ startup_metric_utils::RecordBrowserWindowFirstPaint(base::TimeTicks::Now());
+
+#if defined(OS_MACOSX)
+ if (!compositor) {
+ // In Cocoa version of Chromium, UI is rendered inside the main process
+ // using CoreAnimation compositor, and at this point everything is already
+ // visible to the user.
+ startup_metric_utils::RecordBrowserWindowFirstPaintCompositingEnded(
+ base::TimeTicks::Now());
+ return;
+ }
+#endif // OS_MACOSX
+
+ scoped_observer_.Add(compositor);
+}
+
+BrowserWindowHistogramHelper::~BrowserWindowHistogramHelper() {}
+
+// static
+std::unique_ptr<BrowserWindowHistogramHelper>
+BrowserWindowHistogramHelper::RecordValueAndMaybeCreateInstanceOnBrowserPainted(
+ ui::Compositor* compositor) {
+ static bool did_first_paint = false;
+ if (did_first_paint)
+ return std::unique_ptr<BrowserWindowHistogramHelper>();
+
+ did_first_paint = true;
+
+ return std::unique_ptr<BrowserWindowHistogramHelper>(
+ new BrowserWindowHistogramHelper(compositor));
+}
+
+// OnCompositingEnded was removed crbug.com/671202, this is the next best thing.
+void BrowserWindowHistogramHelper::OnCompositingStarted(
+ ui::Compositor* compositor,
+ base::TimeTicks start_time) {
+ startup_metric_utils::RecordBrowserWindowFirstPaintCompositingEnded(
+ base::TimeTicks::Now());
+
+ scoped_observer_.RemoveAll();
+}
+
+void BrowserWindowHistogramHelper::OnCompositingShuttingDown(
+ ui::Compositor* compositor) {
+ scoped_observer_.RemoveAll();
+}

Powered by Google App Engine
This is Rietveld 408576698