Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: chrome/browser/metrics/browser_view_histogram_helper.h

Issue 2773973002: Add Startup.BrowserView.FirstPaint / .CompositingEnded histograms. (Closed)
Patch Set: Rebase on recent Chromium, address sky's remarks. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_METRICS_BROWSER_VIEW_HISTOGRAM_HELPER_H_
6 #define CHROME_BROWSER_METRICS_BROWSER_VIEW_HISTOGRAM_HELPER_H_
7
8 #include "base/macros.h"
9 #include "base/scoped_observer.h"
10 #include "base/time/time.h"
11 #include "ui/compositor/compositor_observer.h"
12
13 // Class that encapsulates logic of recording
14 // Startup.BrowserView.Paint-histograms.
15 class BrowserViewHistogramHelper : public ui::CompositorObserver {
sky 2017/04/12 19:34:08 BrowserView is specific to views, please name this
themblsha 2017/04/17 17:34:49 Done.
16 public:
17 BrowserViewHistogramHelper();
18 ~BrowserViewHistogramHelper() override;
19
20 // Call this when the Browser finishes painting its UI, and the user will see
21 // it after next Compositor frame swap.
22 // |compositor| is the compositor that composites the just-painted Browser
23 // widget, or nullptr in Cocoa (we're using CoreAnimation's compositor there).
24 void OnBrowserPainted(ui::Compositor* compositor);
25
26 private:
27 void RemoveCompositorObserver();
28
29 // ui::CompositorObserver:
30 void OnCompositingDidCommit(ui::Compositor* compositor) override {}
31 void OnCompositingStarted(ui::Compositor* compositor,
32 base::TimeTicks start_time) override;
33 void OnCompositingLockStateChanged(ui::Compositor* compositor) override {}
34 void OnCompositingShuttingDown(ui::Compositor* compositor) override;
35
36 ScopedObserver<ui::Compositor, ui::CompositorObserver> scoped_observer_;
37 bool did_first_paint_ = false;
38
39 DISALLOW_COPY_AND_ASSIGN(BrowserViewHistogramHelper);
40 };
41
42 #endif // CHROME_BROWSER_METRICS_BROWSER_VIEW_HISTOGRAM_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/metrics/browser_view_histogram_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698