Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: chrome/browser/metrics/browser_window_histogram_helper.cc

Issue 2773973002: Add Startup.BrowserView.FirstPaint / .CompositingEnded histograms. (Closed)
Patch Set: Fix asvitkine's remarks. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/metrics/browser_window_histogram_helper.h"
6
7 #include "components/startup_metric_utils/browser/startup_metric_utils.h"
8 #include "ui/compositor/compositor.h"
9
10 BrowserWindowHistogramHelper::BrowserWindowHistogramHelper(
sky 2017/04/19 20:05:08 Style guide says positions of definition and decla
themblsha 2017/04/20 10:42:23 Done, thanks. Would be nice to have an automated c
11 ui::Compositor* compositor)
12 : scoped_observer_(this) {
13 startup_metric_utils::RecordBrowserWindowFirstPaint(base::TimeTicks::Now());
14
15 #if defined(OS_MACOSX)
16 if (!compositor) {
17 // In Cocoa version of Chromium, UI is rendered inside the main process
18 // using CoreAnimation compositor, and at this point everything is already
19 // visible to the user.
20 startup_metric_utils::RecordBrowserWindowFirstPaintCompositingEnded(
21 base::TimeTicks::Now());
22 return;
23 }
24 #endif // OS_MACOSX
25
26 scoped_observer_.Add(compositor);
27 }
28
29 BrowserWindowHistogramHelper::~BrowserWindowHistogramHelper() {}
30
31 // static
32 std::unique_ptr<BrowserWindowHistogramHelper>
33 BrowserWindowHistogramHelper::MaybeRecordValueAndCreateInstanceOnBrowserPaint(
34 ui::Compositor* compositor) {
35 static bool did_first_paint = false;
36 if (did_first_paint)
37 return std::unique_ptr<BrowserWindowHistogramHelper>();
38
39 did_first_paint = true;
40
41 return std::unique_ptr<BrowserWindowHistogramHelper>(
42 new BrowserWindowHistogramHelper(compositor));
43 }
44
45 // OnCompositingEnded was removed crbug.com/671202, this is the next best thing.
46 void BrowserWindowHistogramHelper::OnCompositingStarted(
47 ui::Compositor* compositor,
48 base::TimeTicks start_time) {
49 startup_metric_utils::RecordBrowserWindowFirstPaintCompositingEnded(
50 base::TimeTicks::Now());
51
52 scoped_observer_.RemoveAll();
53 }
54
55 void BrowserWindowHistogramHelper::OnCompositingShuttingDown(
56 ui::Compositor* compositor) {
57 scoped_observer_.RemoveAll();
58 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698