third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h - Issue 2773883003: Add CompositionMarkerList in preparation for DocumentMarkerController refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2773883003: Add CompositionMarkerList in preparation for DocumentMarkerController refactor (Closed)

Patch Set: Respond to comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h » ('j') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

index 7d56b8a499759acaa533cd738a4fb483e50e3220..d68681b191819b80a8ea6beca0da9e33bb88b949 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

@@ -63,6 +63,7 @@ class CORE_EXPORT DocumentMarkerController final

explicit DocumentMarkerController(Document&);

void clear();

+ void addMarker(Node*, const DocumentMarker&);

void addMarker(const Position& start,

const Position& end,

DocumentMarker::MarkerType,

@@ -139,8 +140,6 @@ class CORE_EXPORT DocumentMarkerController final

unsigned newLength) final;

private:

- void addMarker(Node*, const DocumentMarker&);

using MarkerList = HeapVector<Member<RenderedDocumentMarker>>;

using MarkerLists =

HeapVector<Member<MarkerList>, DocumentMarker::MarkerTypeIndexesCount>;