Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2773843002: Fix state management of transform feedback buffers. (Closed)
Patch Set: Implemented proper attach/detach/unbind for WebGLTransformFeedback. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
index ea72408469dd638c7590bb90167b83e097b789a6..06bb0d08388652c1b4500bb47dc6702e748d380f 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
@@ -972,6 +972,9 @@ class WebGL2RenderingContextBase : public WebGLRenderingContextBase {
MaybeShared<DOMArrayBufferView> pixels) override;
void RestoreCurrentFramebuffer() override;
+ /* Helpers */
+ GLint GetMaxTransformFeedbackSeparateAttribs() const;
+
DECLARE_VIRTUAL_TRACE();
DECLARE_VIRTUAL_TRACE_WRAPPERS();
@@ -1106,6 +1109,9 @@ class WebGL2RenderingContextBase : public WebGLRenderingContextBase {
TraceWrapperMember<WebGLFramebuffer> read_framebuffer_binding_;
TraceWrapperMember<WebGLTransformFeedback> transform_feedback_binding_;
+ // This instance isn't exposed to JavaScript, which is why it's a
+ // Member rather than TraceWrapperMember.
+ Member<WebGLTransformFeedback> default_transform_feedback_;
std::set<GLenum> supported_internal_formats_storage_;
std::set<GLenum> compressed_texture_formats_etc2eac_;
@@ -1114,11 +1120,8 @@ class WebGL2RenderingContextBase : public WebGLRenderingContextBase {
TraceWrapperMember<WebGLBuffer> bound_copy_write_buffer_;
TraceWrapperMember<WebGLBuffer> bound_pixel_pack_buffer_;
TraceWrapperMember<WebGLBuffer> bound_pixel_unpack_buffer_;
- TraceWrapperMember<WebGLBuffer> bound_transform_feedback_buffer_;
TraceWrapperMember<WebGLBuffer> bound_uniform_buffer_;
- HeapVector<TraceWrapperMember<WebGLBuffer>>
- bound_indexed_transform_feedback_buffers_;
HeapVector<TraceWrapperMember<WebGLBuffer>> bound_indexed_uniform_buffers_;
GLint max_transform_feedback_separate_attribs_;
size_t max_bound_uniform_buffer_index_;
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698