content/browser/indexed_db/indexed_db_data_format_version.cc - Issue 2773823002: Use a two-part data format version in IndexedDB metadata.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/indexed_db/indexed_db_data_format_version.cc

Issue 2773823002: Use a two-part data format version in IndexedDB metadata. (Closed)

Patch Set: static Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_data_format_version.h ('k') | content/browser/indexed_db/indexed_db_factory_unittest.cc » ('j') | content/browser/indexed_db/indexed_db_factory_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/browser/indexed_db/indexed_db_data_format_version.h"

	6

	7 #include "third_party/WebKit/public/web/WebSerializedScriptValueVersion.h"

	8

	9 namespace content {

	10

	11 // static

	12 IndexedDBDataFormatVersion IndexedDBDataFormatVersion::current_(

	13 0,

	14 blink::kSerializedScriptValueVersion);
	dcheng 2017/04/06 21:14:19 Is there a guarantee that this will avoid runtime Is there a guarantee that this will avoid runtime initialization? jbroman 2017/04/06 21:26:25 The type has a constexpr constructor, so it's cert Show quoted text On 2017/04/06 at 21:14:19, dcheng wrote: > Is there a guarantee that this will avoid runtime initialization? The type has a constexpr constructor, so it's certainly permitted to avoid it. I've checked that at least gcc and clang do (indeed it's _really_ easy for them to). It's a little more work for me to check MSVC, but I'd be surprised if it didn't do the right thing here. Technically I'm not sure the language forbids compilers from putting runtime initialization for any variable with static initialization if it wants, so I don't know how I can guarantee this other than saying that I've checked two compilers, and I'd expect the sizes alarm to go off if I'm wrong. I can't make the whole thing constexpr because I actually want this to be a mutable static field, for tests. But this should compile down to the obvious thing (8 bytes in the .data section or equivalent).
	15

	16 } // namespace content

OLD	NEW