Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2773813004: MD Settings: Fix About page exception with Advanced lazy loading (Closed)
Patch Set: reorder Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js
diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
index 600499e704e72bcd590b9649e15e087b4fd2290b..268f2af25fbcb40373d0105c89ce11871ba7b40b 100644
--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
@@ -144,7 +144,9 @@ var MainPageBehaviorImpl = {
promise = this.expandSection_(currentSection);
else if (scrollToSection)
currentSection.scrollIntoView();
- } else if (settings.Route.ADVANCED.contains(currentRoute) &&
+ } else if (
+ this.tagName == 'SETTINGS-BASIC-PAGE' &&
+ settings.Route.ADVANCED.contains(currentRoute) &&
// Need to exclude routes that correspond to 'non-sectioned' children of
// ADVANCED, otherwise tryTransitionToSection_ will recurse endlessly.
!currentRoute.isNavigableDialog) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698