Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/crashpad/crashpad/util/file/file_reader.h

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)
Patch Set: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/file/file_reader.h
diff --git a/third_party/crashpad/crashpad/util/file/file_reader.h b/third_party/crashpad/crashpad/util/file/file_reader.h
index 39225e54ae00fc0719e4d9d249f6b8654eabcaef..d44be1c142f268161ff2a25b401c6d05f57d8f76 100644
--- a/third_party/crashpad/crashpad/util/file/file_reader.h
+++ b/third_party/crashpad/crashpad/util/file/file_reader.h
@@ -15,7 +15,6 @@
#ifndef CRASHPAD_UTIL_FILE_FILE_READER_H_
#define CRASHPAD_UTIL_FILE_FILE_READER_H_
-#include <stdio.h>
#include <sys/types.h>
#include "base/files/file_path.h"
@@ -42,7 +41,7 @@ class FileReaderInterface : public virtual FileSeekerInterface {
//! \brief Wraps Read(), ensuring that the read succeeded and exactly \a size
//! bytes were read.
//!
- //! Semantically, this behaves as LoggingReadFile().
+ //! Semantically, this behaves as LoggingReadFileExactly().
//!
//! \return `true` if the operation succeeded, `false` if it failed, with an
//! error message logged. Short reads are treated as failures.
@@ -142,40 +141,6 @@ class FileReader : public FileReaderInterface {
DISALLOW_COPY_AND_ASSIGN(FileReader);
};
-//! \brief A file reader backed by a standard input/output `FILE*`.
-//!
-//! This class accepts an already-open `FILE*`. It is not responsible for
-//! opening or closing this `FILE*`. Users of this class must ensure that the
-//! `FILE*` is closed appropriately elsewhere. Objects of this class may be used
-//! to read from `FILE*` objects not associated with filesystem-based files,
-//! although special attention should be paid to the Seek() method, which may
-//! not function on `FILE*` objects that do not refer to disk-based files.
-//!
-//! This class is expected to be used when other code is responsible for
-//! opening `FILE*` objects and already provides `FILE*` objects. A good use
-//! would be a WeakStdioFileReader for `stdin`.
-class WeakStdioFileReader : public FileReaderInterface {
- public:
- explicit WeakStdioFileReader(FILE* file);
- ~WeakStdioFileReader() override;
-
- // FileReaderInterface:
- FileOperationResult Read(void* data, size_t size) override;
-
- // FileSeekerInterface:
-
- //! \copydoc FileReaderInterface::Seek()
- //!
- //! \note This method is only guaranteed to function on `FILE*` objects
- //! referring to disk-based files.
- FileOffset Seek(FileOffset offset, int whence) override;
-
- private:
- FILE* file_; // weak
-
- DISALLOW_COPY_AND_ASSIGN(WeakStdioFileReader);
-};
-
} // namespace crashpad
#endif // CRASHPAD_UTIL_FILE_FILE_READER_H_
« no previous file with comments | « third_party/crashpad/crashpad/util/file/file_io_win.cc ('k') | third_party/crashpad/crashpad/util/file/file_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698