third_party/crashpad/crashpad/snapshot/win/process_snapshot_win_test.cc - Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/win/process_snapshot_win_test.cc

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc ('k') | third_party/crashpad/crashpad/test/gmock_main.cc » ('j') | third_party/crashpad/crashpad/util/util.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/win/process_snapshot_win_test.cc

diff --git a/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win_test.cc b/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win_test.cc

index a3e31a4ee28b415ec640c452e5bcf78ef27a15fd..82b2903561735305287c1c359723a1b554a09912 100644

--- a/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win_test.cc

+++ b/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win_test.cc

@@ -48,7 +48,8 @@ void TestImageReaderChild(const base::string16& directory_modification) {

child.Start();

char c;

- ASSERT_TRUE(LoggingReadFile(child.stdout_read_handle(), &c, sizeof(c)));

+ ASSERT_TRUE(

+ LoggingReadFileExactly(child.stdout_read_handle(), &c, sizeof(c)));

ASSERT_EQ(' ', c);

ScopedProcessSuspend suspend(child.process_handle());