Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

third_party/crashpad/crashpad/minidump/minidump_system_info_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 64 matching lines @@
       MinidumpStringAtRVA(file_contents, (*system_info)->CSDVersionRva);
   EXPECT_EQ(kCSDVersionBytes, (*csd_version)->Length);
 }
 
 TEST(MinidumpSystemInfoWriter, Empty) {
   MinidumpFileWriter minidump_file_writer;
   auto system_info_writer = base::WrapUnique(new MinidumpSystemInfoWriter());
 
   system_info_writer->SetCSDVersion(std::string());
 
-  minidump_file_writer.AddStream(std::move(system_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(system_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_SYSTEM_INFO* system_info = nullptr;
   const MINIDUMP_STRING* csd_version = nullptr;
 
   ASSERT_NO_FATAL_FAILURE(
       GetSystemInfoStream(string_file.string(), 0, &system_info, &csd_version));
 
@@ skipping 50 matching lines @@
   system_info_writer->SetOS(kOS);
   system_info_writer->SetOSType(kMinidumpOSTypeWorkstation);
   system_info_writer->SetOSVersion(
       kOSVersionMajor, kOSVersionMinor, kOSVersionBuild);
   system_info_writer->SetCSDVersion(kCSDVersion);
   system_info_writer->SetSuiteMask(kSuiteMask);
   system_info_writer->SetCPUX86VendorString(kCPUVendor);
   system_info_writer->SetCPUX86VersionAndFeatures(kCPUVersion, kCPUFeatures);
   system_info_writer->SetCPUX86AMDExtendedFeatures(kAMDFeatures);
 
-  minidump_file_writer.AddStream(std::move(system_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(system_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_SYSTEM_INFO* system_info = nullptr;
   const MINIDUMP_STRING* csd_version = nullptr;
 
   ASSERT_NO_FATAL_FAILURE(GetSystemInfoStream(
       string_file.string(), strlen(kCSDVersion), &system_info, &csd_version));
 
@@ skipping 39 matching lines @@
   system_info_writer->SetCPUArchitecture(kCPUArchitecture);
   system_info_writer->SetCPULevelAndRevision(kCPULevel, kCPURevision);
   system_info_writer->SetCPUCount(kCPUCount);
   system_info_writer->SetOS(kOS);
   system_info_writer->SetOSType(kMinidumpOSTypeWorkstation);
   system_info_writer->SetOSVersion(
       kOSVersionMajor, kOSVersionMinor, kOSVersionBuild);
   system_info_writer->SetCSDVersion(kCSDVersion);
   system_info_writer->SetCPUOtherFeatures(kCPUFeatures[0], kCPUFeatures[1]);
 
-  minidump_file_writer.AddStream(std::move(system_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(system_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_SYSTEM_INFO* system_info = nullptr;
   const MINIDUMP_STRING* csd_version;
 
   ASSERT_NO_FATAL_FAILURE(GetSystemInfoStream(
       string_file.string(), strlen(kCSDVersion), &system_info, &csd_version));
 
@@ skipping 21 matching lines @@
   auto system_info_writer = base::WrapUnique(new MinidumpSystemInfoWriter());
 
   const MinidumpCPUArchitecture kCPUArchitecture = kMinidumpCPUArchitectureX86;
   const uint32_t kCPUVendor[] = {'uneG', 'Ieni', 'letn'};
 
   system_info_writer->SetCPUArchitecture(kCPUArchitecture);
   system_info_writer->SetCPUX86Vendor(
       kCPUVendor[0], kCPUVendor[1], kCPUVendor[2]);
   system_info_writer->SetCSDVersion(std::string());
 
-  minidump_file_writer.AddStream(std::move(system_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(system_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_SYSTEM_INFO* system_info = nullptr;
   const MINIDUMP_STRING* csd_version;
 
   ASSERT_NO_FATAL_FAILURE(
       GetSystemInfoStream(string_file.string(), 0, &system_info, &csd_version));
 
@@ skipping 59 matching lines @@
   system_snapshot.SetOSServer(true);
   system_snapshot.SetOSVersion(expect_system_info.MajorVersion,
                                expect_system_info.MinorVersion,
                                expect_system_info.BuildNumber,
                                kOSVersionBuild);
 
   auto system_info_writer = base::WrapUnique(new MinidumpSystemInfoWriter());
   system_info_writer->InitializeFromSnapshot(&system_snapshot);
 
   MinidumpFileWriter minidump_file_writer;
-  minidump_file_writer.AddStream(std::move(system_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(system_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_SYSTEM_INFO* system_info = nullptr;
   const MINIDUMP_STRING* csd_version = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetSystemInfoStream(string_file.string(),
                                               strlen(kOSVersionBuild),
                                               &system_info,
                                               &csd_version));
@@ skipping 75 matching lines @@
   system_snapshot.SetOSVersion(expect_system_info.MajorVersion,
                                expect_system_info.MinorVersion,
                                expect_system_info.BuildNumber,
                                kOSVersionBuild);
   system_snapshot.SetNXEnabled(true);
 
   auto system_info_writer = base::WrapUnique(new MinidumpSystemInfoWriter());
   system_info_writer->InitializeFromSnapshot(&system_snapshot);
 
   MinidumpFileWriter minidump_file_writer;
-  minidump_file_writer.AddStream(std::move(system_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(system_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_SYSTEM_INFO* system_info = nullptr;
   const MINIDUMP_STRING* csd_version = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetSystemInfoStream(string_file.string(),
                                               strlen(kOSVersionBuild),
                                               &system_info,
                                               &csd_version));
@@ skipping 17 matching lines @@
             system_info->Cpu.OtherCpuInfo.ProcessorFeatures[1]);
 
   for (size_t index = 0; index < strlen(kOSVersionBuild); ++index) {
     EXPECT_EQ(kOSVersionBuild[index], csd_version->Buffer[index]) << index;
   }
 }
 
 TEST(MinidumpSystemInfoWriterDeathTest, NoCSDVersion) {
   MinidumpFileWriter minidump_file_writer;
   auto system_info_writer = base::WrapUnique(new MinidumpSystemInfoWriter());
-  minidump_file_writer.AddStream(std::move(system_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(system_info_writer)));
 
   StringFile string_file;
   ASSERT_DEATH_CHECK(minidump_file_writer.WriteEverything(&string_file),
                      "csd_version_");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad