Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

third_party/crashpad/crashpad/minidump/minidump_misc_info_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 16 matching lines @@
 #include "base/strings/string16.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "gtest/gtest.h"
 #include "minidump/minidump_file_writer.h"
 #include "minidump/test/minidump_file_writer_test_util.h"
 #include "minidump/test/minidump_writable_test_util.h"
 #include "snapshot/test/test_process_snapshot.h"
 #include "snapshot/test/test_system_snapshot.h"
 #include "util/file/string_file.h"
+#include "util/misc/arraysize_unsafe.h"
 #include "util/stdlib/strlcpy.h"
 
 namespace crashpad {
 namespace test {
 namespace {
 
 template <typename T>
 void GetMiscInfoStream(const std::string& file_contents, const T** misc_info) {
   const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER);
   const size_t kMiscInfoStreamOffset =
@@ skipping 139 matching lines @@
     EXPECT_EQ(expected->XStateData.Features[feature_index].Size,
               observed->XStateData.Features[feature_index].Size);
   }
   EXPECT_EQ(expected->ProcessCookie, observed->ProcessCookie);
 }
 
 TEST(MinidumpMiscInfoWriter, Empty) {
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO expected = {};
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProcessId) {
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
   const uint32_t kProcessId = 12345;
 
   misc_info_writer->SetProcessID(kProcessId);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO expected = {};
   expected.Flags1 = MINIDUMP_MISC1_PROCESS_ID;
   expected.ProcessId = kProcessId;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProcessTimes) {
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
   const time_t kProcessCreateTime = 0x15252f00;
   const uint32_t kProcessUserTime = 10;
   const uint32_t kProcessKernelTime = 5;
 
   misc_info_writer->SetProcessTimes(
       kProcessCreateTime, kProcessUserTime, kProcessKernelTime);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO expected = {};
   expected.Flags1 = MINIDUMP_MISC1_PROCESS_TIMES;
   expected.ProcessCreateTime = kProcessCreateTime;
@@ skipping 12 matching lines @@
   const uint32_t kProcessorMhzLimit = 3300;
   const uint32_t kProcessorMaxIdleState = 5;
   const uint32_t kProcessorCurrentIdleState = 1;
 
   misc_info_writer->SetProcessorPowerInfo(kProcessorMaxMhz,
                                           kProcessorCurrentMhz,
                                           kProcessorMhzLimit,
                                           kProcessorMaxIdleState,
                                           kProcessorCurrentIdleState);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_2* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_2 expected = {};
   expected.Flags1 = MINIDUMP_MISC1_PROCESSOR_POWER_INFO;
   expected.ProcessorMaxMhz = kProcessorMaxMhz;
   expected.ProcessorCurrentMhz = kProcessorCurrentMhz;
   expected.ProcessorMhzLimit = kProcessorMhzLimit;
   expected.ProcessorMaxIdleState = kProcessorMaxIdleState;
   expected.ProcessorCurrentIdleState = kProcessorCurrentIdleState;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProcessIntegrityLevel) {
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
   const uint32_t kProcessIntegrityLevel = 0x2000;
 
   misc_info_writer->SetProcessIntegrityLevel(kProcessIntegrityLevel);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_3* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_3 expected = {};
   expected.Flags1 = MINIDUMP_MISC3_PROCESS_INTEGRITY;
   expected.ProcessIntegrityLevel = kProcessIntegrityLevel;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProcessExecuteFlags) {
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
   const uint32_t kProcessExecuteFlags = 0x13579bdf;
 
   misc_info_writer->SetProcessExecuteFlags(kProcessExecuteFlags);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_3* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_3 expected = {};
   expected.Flags1 = MINIDUMP_MISC3_PROCESS_EXECUTE_FLAGS;
   expected.ProcessExecuteFlags = kProcessExecuteFlags;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProtectedProcess) {
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
   const uint32_t kProtectedProcess = 1;
 
   misc_info_writer->SetProtectedProcess(kProtectedProcess);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_3* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_3 expected = {};
   expected.Flags1 = MINIDUMP_MISC3_PROTECTED_PROCESS;
   expected.ProtectedProcess = kProtectedProcess;
@@ skipping 16 matching lines @@
 
   misc_info_writer->SetTimeZone(kTimeZoneId,
                                 kBias,
                                 kStandardName,
                                 kStandardDate,
                                 kStandardBias,
                                 kDaylightName,
                                 kDaylightDate,
                                 kDaylightBias);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_3* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_3 expected = {};
   expected.Flags1 = MINIDUMP_MISC3_TIMEZONE;
   expected.TimeZoneId = kTimeZoneId;
   expected.TimeZone.Bias = kBias;
   base::string16 standard_name_utf16 = base::UTF8ToUTF16(kStandardName);
   c16lcpy(expected.TimeZone.StandardName,
           standard_name_utf16.c_str(),
-          arraysize(expected.TimeZone.StandardName));
+          ARRAYSIZE_UNSAFE(expected.TimeZone.StandardName));
   memcpy(&expected.TimeZone.StandardDate,
          &kStandardDate,
          sizeof(expected.TimeZone.StandardDate));
   expected.TimeZone.StandardBias = kStandardBias;
   base::string16 daylight_name_utf16 = base::UTF8ToUTF16(kDaylightName);
   c16lcpy(expected.TimeZone.DaylightName,
           daylight_name_utf16.c_str(),
-          arraysize(expected.TimeZone.DaylightName));
+          ARRAYSIZE_UNSAFE(expected.TimeZone.DaylightName));
   memcpy(&expected.TimeZone.DaylightDate,
          &kDaylightDate,
          sizeof(expected.TimeZone.DaylightDate));
   expected.TimeZone.DaylightBias = kDaylightBias;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, TimeZoneStringsOverflow) {
   // This test makes sure that the time zone name strings are truncated properly
   // to the widths of their fields.
 
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
   const uint32_t kTimeZoneId = 2;
   const int32_t kBias = 300;
   MINIDUMP_MISC_INFO_N tmp;
   ALLOW_UNUSED_LOCAL(tmp);
-  std::string standard_name(arraysize(tmp.TimeZone.StandardName) + 1, 's');
+  std::string standard_name(ARRAYSIZE_UNSAFE(tmp.TimeZone.StandardName) + 1,
+                            's');
   const int32_t kStandardBias = 0;
-  std::string daylight_name(arraysize(tmp.TimeZone.DaylightName), 'd');
+  std::string daylight_name(ARRAYSIZE_UNSAFE(tmp.TimeZone.DaylightName), 'd');
   const int32_t kDaylightBias = -60;
 
   // Test using kSystemTimeZero, because not all platforms will be able to
   // provide daylight saving time transition times.
   const SYSTEMTIME kSystemTimeZero = {};
 
   misc_info_writer->SetTimeZone(kTimeZoneId,
                                 kBias,
                                 standard_name,
                                 kSystemTimeZero,
                                 kStandardBias,
                                 daylight_name,
                                 kSystemTimeZero,
                                 kDaylightBias);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_3* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_3 expected = {};
   expected.Flags1 = MINIDUMP_MISC3_TIMEZONE;
   expected.TimeZoneId = kTimeZoneId;
   expected.TimeZone.Bias = kBias;
   base::string16 standard_name_utf16 = base::UTF8ToUTF16(standard_name);
   c16lcpy(expected.TimeZone.StandardName,
           standard_name_utf16.c_str(),
-          arraysize(expected.TimeZone.StandardName));
+          ARRAYSIZE_UNSAFE(expected.TimeZone.StandardName));
   memcpy(&expected.TimeZone.StandardDate,
          &kSystemTimeZero,
          sizeof(expected.TimeZone.StandardDate));
   expected.TimeZone.StandardBias = kStandardBias;
   base::string16 daylight_name_utf16 = base::UTF8ToUTF16(daylight_name);
   c16lcpy(expected.TimeZone.DaylightName,
           daylight_name_utf16.c_str(),
-          arraysize(expected.TimeZone.DaylightName));
+          ARRAYSIZE_UNSAFE(expected.TimeZone.DaylightName));
   memcpy(&expected.TimeZone.DaylightDate,
          &kSystemTimeZero,
          sizeof(expected.TimeZone.DaylightDate));
   expected.TimeZone.DaylightBias = kDaylightBias;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, BuildStrings) {
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
   const char kBuildString[] = "build string";
   const char kDebugBuildString[] = "debug build string";
 
   misc_info_writer->SetBuildString(kBuildString, kDebugBuildString);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_4* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_4 expected = {};
   expected.Flags1 = MINIDUMP_MISC4_BUILDSTRING;
   base::string16 build_string_utf16 = base::UTF8ToUTF16(kBuildString);
   c16lcpy(expected.BuildString,
           build_string_utf16.c_str(),
-          arraysize(expected.BuildString));
+          ARRAYSIZE_UNSAFE(expected.BuildString));
   base::string16 debug_build_string_utf16 =
       base::UTF8ToUTF16(kDebugBuildString);
   c16lcpy(expected.DbgBldStr,
           debug_build_string_utf16.c_str(),
-          arraysize(expected.DbgBldStr));
+          ARRAYSIZE_UNSAFE(expected.DbgBldStr));
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, BuildStringsOverflow) {
   // This test makes sure that the build strings are truncated properly to the
   // widths of their fields.
 
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
   MINIDUMP_MISC_INFO_N tmp;
   ALLOW_UNUSED_LOCAL(tmp);
-  std::string build_string(arraysize(tmp.BuildString) + 1, 'B');
-  std::string debug_build_string(arraysize(tmp.DbgBldStr), 'D');
+  std::string build_string(ARRAYSIZE_UNSAFE(tmp.BuildString) + 1, 'B');
+  std::string debug_build_string(ARRAYSIZE_UNSAFE(tmp.DbgBldStr), 'D');
 
   misc_info_writer->SetBuildString(build_string, debug_build_string);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_4* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_4 expected = {};
   expected.Flags1 = MINIDUMP_MISC4_BUILDSTRING;
   base::string16 build_string_utf16 = base::UTF8ToUTF16(build_string);
   c16lcpy(expected.BuildString,
           build_string_utf16.c_str(),
-          arraysize(expected.BuildString));
+          ARRAYSIZE_UNSAFE(expected.BuildString));
   base::string16 debug_build_string_utf16 =
       base::UTF8ToUTF16(debug_build_string);
   c16lcpy(expected.DbgBldStr,
           debug_build_string_utf16.c_str(),
-          arraysize(expected.DbgBldStr));
+          ARRAYSIZE_UNSAFE(expected.DbgBldStr));
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, XStateData) {
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
   const XSTATE_CONFIG_FEATURE_MSC_INFO kXStateData = {
       sizeof(XSTATE_CONFIG_FEATURE_MSC_INFO),
       1024,
       0x000000000000005f,
       {
           {0, 512},
           {512, 256},
           {768, 128},
           {896, 64},
           {960, 32},
           {0, 0},
           {992, 32},
       }};
 
   misc_info_writer->SetXStateData(kXStateData);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_5* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_5 expected = {};
   expected.XStateData = kXStateData;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProcessCookie) {
   MinidumpFileWriter minidump_file_writer;
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
 
   const uint32_t kProcessCookie = 0x12345678;
 
   misc_info_writer->SetProcessCookie(kProcessCookie);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_5* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_5 expected = {};
   expected.Flags1 = MINIDUMP_MISC5_PROCESS_COOKIE;
   expected.ProcessCookie = kProcessCookie;
@@ skipping 41 matching lines @@
   misc_info_writer->SetTimeZone(kTimeZoneId,
                                 kBias,
                                 kStandardName,
                                 kSystemTimeZero,
                                 kStandardBias,
                                 kDaylightName,
                                 kSystemTimeZero,
                                 kDaylightBias);
   misc_info_writer->SetBuildString(kBuildString, kDebugBuildString);
 
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_4* observed = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &observed));
 
   MINIDUMP_MISC_INFO_4 expected = {};
   expected.Flags1 =
       MINIDUMP_MISC1_PROCESS_ID | MINIDUMP_MISC1_PROCESS_TIMES |
@@ skipping 10 matching lines @@
   expected.ProcessorMaxIdleState = kProcessorMaxIdleState;
   expected.ProcessorCurrentIdleState = kProcessorCurrentIdleState;
   expected.ProcessIntegrityLevel = kProcessIntegrityLevel;
   expected.ProcessExecuteFlags = kProcessExecuteFlags;
   expected.ProtectedProcess = kProtectedProcess;
   expected.TimeZoneId = kTimeZoneId;
   expected.TimeZone.Bias = kBias;
   base::string16 standard_name_utf16 = base::UTF8ToUTF16(kStandardName);
   c16lcpy(expected.TimeZone.StandardName,
           standard_name_utf16.c_str(),
-          arraysize(expected.TimeZone.StandardName));
+          ARRAYSIZE_UNSAFE(expected.TimeZone.StandardName));
   memcpy(&expected.TimeZone.StandardDate,
          &kSystemTimeZero,
          sizeof(expected.TimeZone.StandardDate));
   expected.TimeZone.StandardBias = kStandardBias;
   base::string16 daylight_name_utf16 = base::UTF8ToUTF16(kDaylightName);
   c16lcpy(expected.TimeZone.DaylightName,
           daylight_name_utf16.c_str(),
-          arraysize(expected.TimeZone.DaylightName));
+          ARRAYSIZE_UNSAFE(expected.TimeZone.DaylightName));
   memcpy(&expected.TimeZone.DaylightDate,
          &kSystemTimeZero,
          sizeof(expected.TimeZone.DaylightDate));
   expected.TimeZone.DaylightBias = kDaylightBias;
   base::string16 build_string_utf16 = base::UTF8ToUTF16(kBuildString);
   c16lcpy(expected.BuildString,
           build_string_utf16.c_str(),
-          arraysize(expected.BuildString));
+          ARRAYSIZE_UNSAFE(expected.BuildString));
   base::string16 debug_build_string_utf16 =
       base::UTF8ToUTF16(kDebugBuildString);
   c16lcpy(expected.DbgBldStr,
           debug_build_string_utf16.c_str(),
-          arraysize(expected.DbgBldStr));
+          ARRAYSIZE_UNSAFE(expected.DbgBldStr));
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, InitializeFromSnapshot) {
   MINIDUMP_MISC_INFO_4 expect_misc_info = {};
 
   const char kStandardTimeName[] = "EST";
   const char kDaylightTimeName[] = "EDT";
   const char kOSVersionFull[] =
@@ skipping 22 matching lines @@
   expect_misc_info.ProcessId = 12345;
   expect_misc_info.ProcessCreateTime = 0x555c7740;
   expect_misc_info.ProcessUserTime = 60;
   expect_misc_info.ProcessKernelTime = 15;
   expect_misc_info.ProcessorCurrentMhz = 2800;
   expect_misc_info.ProcessorMaxMhz = 2800;
   expect_misc_info.TimeZoneId = 1;
   expect_misc_info.TimeZone.Bias = 300;
   c16lcpy(expect_misc_info.TimeZone.StandardName,
           standard_time_name_utf16.c_str(),
-          arraysize(expect_misc_info.TimeZone.StandardName));
+          ARRAYSIZE_UNSAFE(expect_misc_info.TimeZone.StandardName));
   expect_misc_info.TimeZone.StandardBias = 0;
   c16lcpy(expect_misc_info.TimeZone.DaylightName,
           daylight_time_name_utf16.c_str(),
-          arraysize(expect_misc_info.TimeZone.DaylightName));
+          ARRAYSIZE_UNSAFE(expect_misc_info.TimeZone.DaylightName));
   expect_misc_info.TimeZone.DaylightBias = -60;
   c16lcpy(expect_misc_info.BuildString,
           build_string_utf16.c_str(),
-          arraysize(expect_misc_info.BuildString));
+          ARRAYSIZE_UNSAFE(expect_misc_info.BuildString));
   c16lcpy(expect_misc_info.DbgBldStr,
           debug_build_string_utf16.c_str(),
-          arraysize(expect_misc_info.DbgBldStr));
+          ARRAYSIZE_UNSAFE(expect_misc_info.DbgBldStr));
 
   const timeval kStartTime =
       { static_cast<time_t>(expect_misc_info.ProcessCreateTime), 0 };
   const timeval kUserCPUTime =
       { static_cast<time_t>(expect_misc_info.ProcessUserTime), 0 };
   const timeval kSystemCPUTime =
       { static_cast<time_t>(expect_misc_info.ProcessKernelTime), 0 };
 
   TestProcessSnapshot process_snapshot;
   process_snapshot.SetProcessID(expect_misc_info.ProcessId);
@@ skipping 13 matching lines @@
                                kDaylightTimeName);
   system_snapshot->SetOSVersionFull(kOSVersionFull);
   system_snapshot->SetMachineDescription(kMachineDescription);
 
   process_snapshot.SetSystem(std::move(system_snapshot));
 
   auto misc_info_writer = base::WrapUnique(new MinidumpMiscInfoWriter());
   misc_info_writer->InitializeFromSnapshot(&process_snapshot);
 
   MinidumpFileWriter minidump_file_writer;
-  minidump_file_writer.AddStream(std::move(misc_info_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(misc_info_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MISC_INFO_4* misc_info = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(string_file.string(), &misc_info));
 
   ExpectMiscInfoEqual(&expect_misc_info, misc_info);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad