Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 84 matching lines @@
 TEST(MinidumpExceptionWriter, Minimal) {
   MinidumpFileWriter minidump_file_writer;
   auto exception_writer = base::WrapUnique(new MinidumpExceptionWriter());
 
   const uint32_t kSeed = 100;
 
   auto context_x86_writer = base::WrapUnique(new MinidumpContextX86Writer());
   InitializeMinidumpContextX86(context_x86_writer->context(), kSeed);
   exception_writer->SetContext(std::move(context_x86_writer));
 
-  minidump_file_writer.AddStream(std::move(exception_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(exception_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_EXCEPTION_STREAM* observed_exception_stream = nullptr;
   ASSERT_NO_FATAL_FAILURE(
       GetExceptionStream(string_file.string(), &observed_exception_stream));
 
   MINIDUMP_EXCEPTION_STREAM expected_exception_stream = {};
   expected_exception_stream.ThreadContext.DataSize = sizeof(MinidumpContextX86);
@@ skipping 38 matching lines @@
   std::vector<uint64_t> exception_information(EXCEPTION_MAXIMUM_PARAMETERS,
                                               0x5a5a5a5a5a5a5a5a);
   exception_writer->SetExceptionInformation(exception_information);
 
   exception_information.clear();
   exception_information.push_back(kExceptionInformation0);
   exception_information.push_back(kExceptionInformation1);
   exception_information.push_back(kExceptionInformation2);
   exception_writer->SetExceptionInformation(exception_information);
 
-  minidump_file_writer.AddStream(std::move(exception_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(exception_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_EXCEPTION_STREAM* observed_exception_stream = nullptr;
   ASSERT_NO_FATAL_FAILURE(
       GetExceptionStream(string_file.string(), &observed_exception_stream));
 
   MINIDUMP_EXCEPTION_STREAM expected_exception_stream = {};
   expected_exception_stream.ThreadId = kThreadID;
@@ skipping 52 matching lines @@
 
   InitializeCPUContextX86(exception_snapshot.MutableContext(), kSeed);
 
   MinidumpThreadIDMap thread_id_map;
   thread_id_map[kThreadID] = expect_exception.ThreadId;
 
   auto exception_writer = base::WrapUnique(new MinidumpExceptionWriter());
   exception_writer->InitializeFromSnapshot(&exception_snapshot, thread_id_map);
 
   MinidumpFileWriter minidump_file_writer;
-  minidump_file_writer.AddStream(std::move(exception_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(exception_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_EXCEPTION_STREAM* exception = nullptr;
   ASSERT_NO_FATAL_FAILURE(GetExceptionStream(string_file.string(), &exception));
 
   const MinidumpContextX86* observed_context = nullptr;
   ASSERT_NO_FATAL_FAILURE(ExpectExceptionStream(&expect_exception,
                                                 exception,
                                                 string_file.string(),
                                                 &observed_context));
 
   ASSERT_NO_FATAL_FAILURE(
       ExpectMinidumpContextX86(kSeed, observed_context, true));
 }
 
 TEST(MinidumpExceptionWriterDeathTest, NoContext) {
   MinidumpFileWriter minidump_file_writer;
   auto exception_writer = base::WrapUnique(new MinidumpExceptionWriter());
 
-  minidump_file_writer.AddStream(std::move(exception_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(exception_writer)));
 
   StringFile string_file;
   ASSERT_DEATH_CHECK(minidump_file_writer.WriteEverything(&string_file),
                      "context_");
 }
 
 TEST(MinidumpExceptionWriterDeathTest, TooMuchInformation) {
   MinidumpExceptionWriter exception_writer;
   std::vector<uint64_t> exception_information(EXCEPTION_MAXIMUM_PARAMETERS + 1,
                                               0x5a5a5a5a5a5a5a5a);
   ASSERT_DEATH_CHECK(
       exception_writer.SetExceptionInformation(exception_information),
       "kMaxParameters");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad