media/filters/chunk_demuxer.cc - Issue 2773793002: Allow mp3 audio codec for mpeg2ts containers in MSE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/chunk_demuxer.cc

Issue 2773793002: Allow mp3 audio codec for mpeg2ts containers in MSE (Closed)

Patch Set: CR feedback Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/chunk_demuxer.cc

diff --git a/media/filters/chunk_demuxer.cc b/media/filters/chunk_demuxer.cc

index e97de2c75d4c2f768bba0262c6112729420e2407..d55b2deef680dcc1592176e63b1476dd26f7954b 100644

--- a/media/filters/chunk_demuxer.cc

+++ b/media/filters/chunk_demuxer.cc

@@ -604,8 +604,11 @@ ChunkDemuxer::Status ChunkDemuxer::AddId(const std::string& id,

std::unique_ptr<media::StreamParser> stream_parser(

StreamParserFactory::Create(type, parsed_codec_ids, media_log_));

- if (!stream_parser)

+ if (!stream_parser) {

+ DVLOG(1) << __func__ << " failed: unsupported mime_type=" << type

+ << " codecs=" << codecs;

return ChunkDemuxer::kNotSupported;

+ }

std::unique_ptr<FrameProcessor> frame_processor(

new FrameProcessor(base::Bind(&ChunkDemuxer::IncreaseDurationIfNecessary,

« no previous file with comments | « media/base/audio_codecs.cc ('k') | media/filters/stream_parser_factory.cc » ('j') | no next file with comments »