Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: media/filters/stream_parser_factory.cc

Issue 2773793002: Allow mp3 audio codec for mpeg2ts containers in MSE (Closed)
Patch Set: Use mp4a.69,mp4a.6B codec ids instead of mp3 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/stream_parser_factory.cc
diff --git a/media/filters/stream_parser_factory.cc b/media/filters/stream_parser_factory.cc
index 0d71f2ac942807b315a5b98b0ccc36a68f97027d..1ce32a8afa0d9508b645bb8677f32d986e001824 100644
--- a/media/filters/stream_parser_factory.cc
+++ b/media/filters/stream_parser_factory.cc
@@ -298,13 +298,18 @@ static StreamParser* BuildADTSParser(const std::vector<std::string>& codecs,
}
#if BUILDFLAG(ENABLE_MSE_MPEG2TS_STREAM_PARSER)
-static const CodecInfo* kVideoMP2TCodecs[] = {
- &kH264AVC1CodecInfo,
- &kH264AVC3CodecInfo,
- &kMPEG4AACCodecInfo,
- &kMPEG2AACLCCodecInfo,
- NULL
-};
+static const CodecInfo kMPEG2TS_MP3CodecInfo1 = {
wolenetz 2017/03/24 17:34:25 nit: please reference the mp4ra object registry si
servolk 2017/03/27 20:10:39 Done.
+ "mp4a.69", CodecInfo::AUDIO, NULL, CodecInfo::HISTOGRAM_MP3};
+static const CodecInfo kMPEG2TS_MP3CodecInfo2 = {
+ "mp4a.6B", CodecInfo::AUDIO, NULL, CodecInfo::HISTOGRAM_MP3};
+
+static const CodecInfo* kVideoMP2TCodecs[] = {&kH264AVC1CodecInfo,
+ &kH264AVC3CodecInfo,
+ &kMPEG2TS_MP3CodecInfo1,
+ &kMPEG2TS_MP3CodecInfo2,
+ &kMPEG4AACCodecInfo,
+ &kMPEG2AACLCCodecInfo,
+ NULL};
static StreamParser* BuildMP2TParser(const std::vector<std::string>& codecs,
const scoped_refptr<MediaLog>& media_log) {

Powered by Google App Engine
This is Rietveld 408576698