Allow mp3 audio codec for mpeg2ts containers in MSE

media/filters/stream_parser_factory.cc

Index: media/filters/stream_parser_factory.cc
diff --git a/media/filters/stream_parser_factory.cc b/media/filters/stream_parser_factory.cc
index 0d71f2ac942807b315a5b98b0ccc36a68f97027d..6cdc97fa6ae8866617e7668bf6524d428efe1e7a 100644
--- a/media/filters/stream_parser_factory.cc
+++ b/media/filters/stream_parser_factory.cc
@@ -298,13 +298,12 @@ static StreamParser* BuildADTSParser(const std::vector<std::string>& codecs,
 }
 
 #if BUILDFLAG(ENABLE_MSE_MPEG2TS_STREAM_PARSER)
+static const CodecInfo kMPEG2TS_MP3CodecInfo = {"mp3", CodecInfo::AUDIO, NULL,

[wolenetz, 2017/03/23 20:17:39]

NOT LGTM until resolved:
Is "mp3" standardized as a codec name for this mime type? For instance, in bug
661749, there is similar request for support for mp3 in mp4, with deliberation
on codec string (none being mp3, candidates are among "mp4a.6B", "mp4a.69", and
(less likely) "mp4a.40.some_x".

Though mp2ts is Chromecast-specific, we probably want to still try to maintain
in upstream at least some adherence to standard codec string names.

See MSE bytestream registry for mp2ts's specifying user agents *should* use
codec strings that conform to https://tools.ietf.org/html/rfc6381.

[servolk, 2017/03/23 23:24:59]

Ah, ok, as we've discussed offline, you are right - mp4a.6B and mp4a.69 seem to
be more standard-compliant codec ids for mp3. I've update the CL to use those
two codec ids instead of mp3.

+                                                CodecInfo::HISTOGRAM_MP3};
+
 static const CodecInfo* kVideoMP2TCodecs[] = {
-  &kH264AVC1CodecInfo,
-  &kH264AVC3CodecInfo,
-  &kMPEG4AACCodecInfo,
-  &kMPEG2AACLCCodecInfo,
-  NULL
-};
+    &kH264AVC1CodecInfo, &kH264AVC3CodecInfo,   &kMPEG2TS_MP3CodecInfo,
+    &kMPEG4AACCodecInfo, &kMPEG2AACLCCodecInfo, NULL};
 
 static StreamParser* BuildMP2TParser(const std::vector<std::string>& codecs,
                                      const scoped_refptr<MediaLog>& media_log) {