Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 2773693002: Re-enable benchmarks for reference builds on Nexus 5X. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index 6a273c3e9f68c31e9e5ef7f12698d73597e071b9..2a07621d7fd12ef766de3f0c43d7521f8484a476 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -39,11 +39,6 @@ class V8Top25(perf_benchmark.PerfBenchmark):
page_set = page_sets.V8Top25SmoothPageSet
@classmethod
- def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
- return (possible_browser.browser_type == 'reference' and
- possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
-
- @classmethod
def Name(cls):
return 'v8.top_25_smooth'
@@ -62,11 +57,6 @@ class V8KeyMobileSites(perf_benchmark.PerfBenchmark):
def Name(cls):
return 'v8.key_mobile_sites_smooth'
- @classmethod
- def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
- return (possible_browser.browser_type == 'reference' and
- possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
-
class V8DetachedContextAgeInGC(perf_benchmark.PerfBenchmark):
"""Measures the number of GCs needed to collect a detached context.
@@ -243,11 +233,6 @@ class V8MobileInfiniteScroll(_InfiniteScrollBenchmark):
def Name(cls):
return 'v8.mobile_infinite_scroll_tbmv2'
- @classmethod
- def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
- return (possible_browser.browser_type == 'reference' and
- possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
-
@benchmark.Disabled('all') # was enabled only on android
@benchmark.Owner(emails=['mvstaton@chromium.org'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698