Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: ui/events/blink/input_handler_proxy.cc

Issue 2773593005: Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (Closed)
Patch Set: Add unit tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/blink/input_handler_proxy.cc
diff --git a/ui/events/blink/input_handler_proxy.cc b/ui/events/blink/input_handler_proxy.cc
index ca73fa685c4c7e8d197a58dc4e41dff4accc6d45..b96479426f396c0058696a7b5708899ee2c5f236 100644
--- a/ui/events/blink/input_handler_proxy.cc
+++ b/ui/events/blink/input_handler_proxy.cc
@@ -557,6 +557,9 @@ void InputHandlerProxy::RecordMainThreadScrollingReasons(
return;
}
+ // NonCompositedScrollReasons should only be set on the main thread.
+ DCHECK(!cc::MainThreadScrollingReason::NonCompositedScrollReasons(reasons));
bokan 2017/04/07 17:39:03 I think this check isn't what you want. The functi
yigu 2017/04/07 19:26:27 Done.
+
// UMA_HISTOGRAM_ENUMERATION requires that the enum_max must be strictly
// greater than the sample value. kMainThreadScrollingReasonCount doesn't
// include the NotScrollingOnMain enum but the histograms do so adding

Powered by Google App Engine
This is Rietveld 408576698