Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: third_party/WebKit/Source/core/input/ScrollManager.h

Issue 2773593005: Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (Closed)
Patch Set: nit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ScrollManager_h 5 #ifndef ScrollManager_h
6 #define ScrollManager_h 6 #define ScrollManager_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/page/EventWithHitTestResults.h" 9 #include "core/page/EventWithHitTestResults.h"
10 #include "platform/geometry/LayoutSize.h" 10 #include "platform/geometry/LayoutSize.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 bool canHandleGestureEvent(const GestureEventWithHitTestResults&); 84 bool canHandleGestureEvent(const GestureEventWithHitTestResults&);
85 85
86 // These functions are related to |m_resizeScrollableArea|. 86 // These functions are related to |m_resizeScrollableArea|.
87 bool inResizeMode() const; 87 bool inResizeMode() const;
88 void resize(const WebMouseEvent&); 88 void resize(const WebMouseEvent&);
89 // Clears |m_resizeScrollableArea|. if |shouldNotBeNull| is true this 89 // Clears |m_resizeScrollableArea|. if |shouldNotBeNull| is true this
90 // function DCHECKs to make sure that variable is indeed not null. 90 // function DCHECKs to make sure that variable is indeed not null.
91 void clearResizeScrollableArea(bool shouldNotBeNull); 91 void clearResizeScrollableArea(bool shouldNotBeNull);
92 void setResizeScrollableArea(PaintLayer*, IntPoint); 92 void setResizeScrollableArea(PaintLayer*, IntPoint);
93 93
94 // Record main thread scrolling reasons. This should be no-op;
bokan 2017/03/24 17:55:54 Why does this say it should be a no-op? Recording
yigu 2017/03/27 21:02:07 Done.
95 uint32_t computeMainThreadScrollingReasons(const Node&);
96 void recordMainThreadScrollingReasons(const uint32_t reasons,
97 const WebGestureDevice);
98
94 private: 99 private:
95 WebInputEventResult handleGestureScrollUpdate(const WebGestureEvent&); 100 WebInputEventResult handleGestureScrollUpdate(const WebGestureEvent&);
96 WebInputEventResult handleGestureScrollBegin(const WebGestureEvent&); 101 WebInputEventResult handleGestureScrollBegin(const WebGestureEvent&);
97 102
98 WebInputEventResult passScrollGestureEvent(const WebGestureEvent&, 103 WebInputEventResult passScrollGestureEvent(const WebGestureEvent&,
99 LayoutObject*); 104 LayoutObject*);
100 105
101 void clearGestureScrollState(); 106 void clearGestureScrollState();
102 107
103 void customizedScroll(const Node& startNode, ScrollState&); 108 void customizedScroll(const Node& startNode, ScrollState&);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 145
141 Member<PaintLayerScrollableArea> m_resizeScrollableArea; 146 Member<PaintLayerScrollableArea> m_resizeScrollableArea;
142 147
143 LayoutSize 148 LayoutSize
144 m_offsetFromResizeCorner; // In the coords of m_resizeScrollableArea. 149 m_offsetFromResizeCorner; // In the coords of m_resizeScrollableArea.
145 }; 150 };
146 151
147 } // namespace blink 152 } // namespace blink
148 153
149 #endif // ScrollManager_h 154 #endif // ScrollManager_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698