Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2773593005: Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (Closed)
Patch Set: nit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 784 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 // don't, both A and C should scroll on cc. Frame D should 795 // don't, both A and C should scroll on cc. Frame D should
796 // scrolled on main thread as its ancestor B. 796 // scrolled on main thread as its ancestor B.
797 void UpdateSubFrameScrollOnMainReason(const Frame&, 797 void UpdateSubFrameScrollOnMainReason(const Frame&,
798 MainThreadScrollingReasons); 798 MainThreadScrollingReasons);
799 String MainThreadScrollingReasonsAsText() const; 799 String MainThreadScrollingReasonsAsText() const;
800 // Main thread scrolling reasons including reasons from ancestors. 800 // Main thread scrolling reasons including reasons from ancestors.
801 MainThreadScrollingReasons GetMainThreadScrollingReasons() const; 801 MainThreadScrollingReasons GetMainThreadScrollingReasons() const;
802 // Main thread scrolling reasons for this object only. For all reasons, 802 // Main thread scrolling reasons for this object only. For all reasons,
803 // see: mainThreadScrollingReasons(). 803 // see: mainThreadScrollingReasons().
804 MainThreadScrollingReasons MainThreadScrollingReasonsPerFrame() const; 804 MainThreadScrollingReasons MainThreadScrollingReasonsPerFrame() const;
805 void AdjustStyleRelatedMainThreadScrollingReasons(const uint32_t reason,
806 bool increase);
807 MainThreadScrollingReasons GetStyleRelatedMainThreadScrollingReasons() const;
808 805
809 bool HasVisibleSlowRepaintViewportConstrainedObjects() const; 806 bool HasVisibleSlowRepaintViewportConstrainedObjects() const;
810 807
811 // Called on a view for a LocalFrame with a RemoteFrame parent. This makes 808 // Called on a view for a LocalFrame with a RemoteFrame parent. This makes
812 // viewport intersection available that accounts for remote ancestor frames 809 // viewport intersection available that accounts for remote ancestor frames
813 // and their respective scroll positions, clips, etc. 810 // and their respective scroll positions, clips, etc.
814 void SetViewportIntersectionFromParent(const IntRect&); 811 void SetViewportIntersectionFromParent(const IntRect&);
815 IntRect RemoteViewportIntersection(); 812 IntRect RemoteViewportIntersection();
816 813
817 // This method uses localToAncestorQuad to map a rect into an ancestor's 814 // This method uses localToAncestorQuad to map a rect into an ancestor's
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
1213 }; 1210 };
1214 std::unique_ptr<Vector<ObjectPaintInvalidation>> 1211 std::unique_ptr<Vector<ObjectPaintInvalidation>>
1215 tracked_object_paint_invalidations_; 1212 tracked_object_paint_invalidations_;
1216 1213
1217 // For Slimming Paint v2 only. 1214 // For Slimming Paint v2 only.
1218 std::unique_ptr<PaintController> paint_controller_; 1215 std::unique_ptr<PaintController> paint_controller_;
1219 std::unique_ptr<PaintArtifactCompositor> paint_artifact_compositor_; 1216 std::unique_ptr<PaintArtifactCompositor> paint_artifact_compositor_;
1220 1217
1221 bool is_storing_composited_layer_debug_info_; 1218 bool is_storing_composited_layer_debug_info_;
1222 MainThreadScrollingReasons main_thread_scrolling_reasons_; 1219 MainThreadScrollingReasons main_thread_scrolling_reasons_;
1223 // For recording main thread scrolling reasons
1224 // due to layout object properties. e.g. opacity, transform.
1225 // The size of the vector depends on the number of
1226 // main thread scrolling reasons.
1227 Vector<int> main_thread_scrolling_reasons_counter_;
1228 1220
1229 // TODO(kenrb): Remove these when https://crbug.com/680606 is resolved. 1221 // TODO(kenrb): Remove these when https://crbug.com/680606 is resolved.
1230 std::unique_ptr<CompositorAnimationTimeline> animation_timeline_; 1222 std::unique_ptr<CompositorAnimationTimeline> animation_timeline_;
1231 std::unique_ptr<CompositorAnimationHost> animation_host_; 1223 std::unique_ptr<CompositorAnimationHost> animation_host_;
1232 1224
1233 Member<PrintContext> print_context_; 1225 Member<PrintContext> print_context_;
1234 1226
1235 FRIEND_TEST_ALL_PREFIXES(WebViewTest, DeviceEmulationResetScrollbars); 1227 FRIEND_TEST_ALL_PREFIXES(WebViewTest, DeviceEmulationResetScrollbars);
1236 }; 1228 };
1237 1229
(...skipping 28 matching lines...) Expand all
1266 frameViewBase.IsFrameView()); 1258 frameViewBase.IsFrameView());
1267 DEFINE_TYPE_CASTS(FrameView, 1259 DEFINE_TYPE_CASTS(FrameView,
1268 ScrollableArea, 1260 ScrollableArea,
1269 scrollableArea, 1261 scrollableArea,
1270 scrollableArea->IsFrameView(), 1262 scrollableArea->IsFrameView(),
1271 scrollableArea.IsFrameView()); 1263 scrollableArea.IsFrameView());
1272 1264
1273 } // namespace blink 1265 } // namespace blink
1274 1266
1275 #endif // FrameView_h 1267 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698