Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager

third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 1021 matching lines @@
   } else {
     ASSERT_TRUE(scrollLayer);
     webScrollLayer = scrollLayer->platformLayer();
     ASSERT_TRUE(webScrollLayer->scrollable());
     ASSERT_FALSE(
         webScrollLayer->mainThreadScrollingReasons() &
         MainThreadScrollingReason::kHasNonLayerViewportConstrainedObjects);
   }
 }
 
-class StyleRelatedMainThreadScrollingReasonTest
+class NonCompositedMainThreadScrollingReasonTest
     : public ScrollingCoordinatorTest {
   static const uint32_t m_LCDTextRelatedReasons =
       MainThreadScrollingReason::kHasOpacityAndLCDText |
       MainThreadScrollingReason::kHasTransformAndLCDText |
       MainThreadScrollingReason::kBackgroundNotOpaqueInRectAndLCDText;
 
  protected:
-  StyleRelatedMainThreadScrollingReasonTest() {
+  NonCompositedMainThreadScrollingReasonTest() {
     registerMockedHttpURLLoad("two_scrollable_area.html");
     navigateTo(m_baseURL + "two_scrollable_area.html");
   }
   void testStyle(const std::string& target, const uint32_t reason) {
     webViewImpl()->settings()->setPreferCompositingToLCDTextEnabled(false);

[bokan, 2017/04/06 21:45:10]

We should probably have a test that runs with this flag on.

[yigu, 2017/04/07 16:35:32]

The last part of this function tests with the flag on. The LCDTextRelatedReasons
would only be set when the flag is off.

     Document* document = frame()->document();
     Element* container = document->getElementById("scroller1");
-    container->setAttribute("class", target.c_str(), ASSERT_NO_EXCEPTION);
-    container = document->getElementById("scroller2");
+    DCHECK(container);
     container->setAttribute("class", target.c_str(), ASSERT_NO_EXCEPTION);
     forceFullCompositingUpdate();
 
+    // Add or remove style related attribute from a scroller shouldn't

[bokan, 2017/04/06 21:45:10]

Nothing below has to do with the main frame so I'm not sure what this comment is
about.

[yigu, 2017/04/07 16:35:32]

Done.

+    // affect the main frame which is supposed to scroll on impl during
+    // this test.
+    PaintLayerScrollableArea* scrollableArea =
+        toLayoutBoxModelObject(container->layoutObject())->getScrollableArea();
+    ASSERT_TRUE(scrollableArea);
+    ASSERT_TRUE(scrollableArea->getNonCompositedMainThreadScrollingReasons() &
+                reason);
+
+    container = document->getElementById("scroller2");
+    scrollableArea =
+        toLayoutBoxModelObject(container->layoutObject())->getScrollableArea();
+    ASSERT_TRUE(scrollableArea);
+    // Different scrollable area should keep unaffected.
+    ASSERT_FALSE(scrollableArea->getNonCompositedMainThreadScrollingReasons() &
+                 reason);
+
     FrameView* frameView = frame()->view();
     ASSERT_TRUE(frameView);
-    ASSERT_TRUE(frameView->mainThreadScrollingReasons() & reason);
+    ASSERT_FALSE(frameView->mainThreadScrollingReasons() & reason);
 
-    // Remove the target attribute from one of the scrollers.
-    // Still need to scroll on main thread.
+    // Remove attribute from the scroller would lead to scroll on impl.
     container = document->getElementById("scroller1");

[bokan, 2017/04/06 21:45:10]

better to have two variables in this test, scroller1 and scroller2, rather than
reusing container for both. Ditto for the ScrollableAreas.

[yigu, 2017/04/07 16:35:32]

Done.

-    DCHECK(container);
-
     container->removeAttribute("class");
     forceFullCompositingUpdate();
 
-    ASSERT_TRUE(frameView->mainThreadScrollingReasons() & reason);
-
-    // Remove attribute from the other scroller would lead to
-    // scroll on impl.
-    container = document->getElementById("scroller2");
-    DCHECK(container);
-
-    container->removeAttribute("class");
-    forceFullCompositingUpdate();
-
+    scrollableArea =
+        toLayoutBoxModelObject(container->layoutObject())->getScrollableArea();
+    ASSERT_TRUE(scrollableArea);
+    ASSERT_FALSE(scrollableArea->getNonCompositedMainThreadScrollingReasons() &
+                 reason);
     ASSERT_FALSE(frameView->mainThreadScrollingReasons() & reason);
 
     // Add target attribute would again lead to scroll on main thread
     container->setAttribute("class", target.c_str(), ASSERT_NO_EXCEPTION);
     forceFullCompositingUpdate();
 
-    ASSERT_TRUE(frameView->mainThreadScrollingReasons() & reason);
+    ASSERT_TRUE(scrollableArea->getNonCompositedMainThreadScrollingReasons() &
+                reason);
+    ASSERT_FALSE(frameView->mainThreadScrollingReasons() & reason);
 
     if ((reason & m_LCDTextRelatedReasons) &&
         !(reason & ~m_LCDTextRelatedReasons)) {
       webViewImpl()->settings()->setPreferCompositingToLCDTextEnabled(true);
       forceFullCompositingUpdate();
+      ASSERT_FALSE(
+          scrollableArea->getNonCompositedMainThreadScrollingReasons() &
+          reason);
       ASSERT_FALSE(frameView->mainThreadScrollingReasons());
     }
   }
 };
 
 INSTANTIATE_TEST_CASE_P(All,
-                        StyleRelatedMainThreadScrollingReasonTest,
+                        NonCompositedMainThreadScrollingReasonTest,
                         ::testing::Bool());
 
-// TODO(yigu): This test and all other style realted main thread scrolling
-// reason tests below have been disabled due to https://crbug.com/701355.
-TEST_P(StyleRelatedMainThreadScrollingReasonTest, DISABLED_TransparentTest) {
+TEST_P(NonCompositedMainThreadScrollingReasonTest, TransparentTest) {
   testStyle("transparent", MainThreadScrollingReason::kHasOpacityAndLCDText);
 }
 
-TEST_P(StyleRelatedMainThreadScrollingReasonTest, DISABLED_TransformTest) {
+TEST_P(NonCompositedMainThreadScrollingReasonTest, TransformTest) {
   testStyle("transform", MainThreadScrollingReason::kHasTransformAndLCDText);
 }
 
-TEST_P(StyleRelatedMainThreadScrollingReasonTest,
-       DISABLED_BackgroundNotOpaqueTest) {
+TEST_P(NonCompositedMainThreadScrollingReasonTest, BackgroundNotOpaqueTest) {
   testStyle("background-not-opaque",
             MainThreadScrollingReason::kBackgroundNotOpaqueInRectAndLCDText);
 }
 
-TEST_P(StyleRelatedMainThreadScrollingReasonTest, DISABLED_BorderRadiusTest) {
+TEST_P(NonCompositedMainThreadScrollingReasonTest, BorderRadiusTest) {
   testStyle("border-radius", MainThreadScrollingReason::kHasBorderRadius);
 }
 
-TEST_P(StyleRelatedMainThreadScrollingReasonTest, DISABLED_ClipTest) {
+TEST_P(NonCompositedMainThreadScrollingReasonTest, ClipTest) {
   testStyle("clip", MainThreadScrollingReason::kHasClipRelatedProperty);
 }
 
-TEST_P(StyleRelatedMainThreadScrollingReasonTest, DISABLED_ClipPathTest) {
+TEST_P(NonCompositedMainThreadScrollingReasonTest, ClipPathTest) {
   uint32_t reason = MainThreadScrollingReason::kHasClipRelatedProperty;
   webViewImpl()->settings()->setPreferCompositingToLCDTextEnabled(false);
   Document* document = frame()->document();
   // Test ancestor with ClipPath
   Element* element = document->body();
   DCHECK(element);
   element->setAttribute(HTMLNames::styleAttr,
                         "clip-path:circle(115px at 20px 20px);");
+  Element* container = document->getElementById("scroller1");
+  DCHECK(container);
   forceFullCompositingUpdate();
 
+  PaintLayerScrollableArea* scrollableArea =
+      toLayoutBoxModelObject(container->layoutObject())->getScrollableArea();
+  ASSERT_TRUE(scrollableArea);
+  ASSERT_TRUE(scrollableArea->getNonCompositedMainThreadScrollingReasons() &
+              reason);
+
   FrameView* frameView = frame()->view();
   ASSERT_TRUE(frameView);
-  ASSERT_TRUE(frameView->mainThreadScrollingReasons() & reason);
+  ASSERT_FALSE(frameView->mainThreadScrollingReasons() & reason);
 
   // Remove clip path from ancestor.
   element->removeAttribute(HTMLNames::styleAttr);
   forceFullCompositingUpdate();
 
+  ASSERT_FALSE(scrollableArea->getNonCompositedMainThreadScrollingReasons() &
+               reason);
   ASSERT_FALSE(frameView->mainThreadScrollingReasons() & reason);
 
   // Test descendant with ClipPath
   element = document->getElementById("content1");
   DCHECK(element);
   element->setAttribute(HTMLNames::styleAttr,
                         "clip-path:circle(115px at 20px 20px);");
   forceFullCompositingUpdate();
-  ASSERT_TRUE(frameView->mainThreadScrollingReasons() & reason);
+  ASSERT_TRUE(scrollableArea->getNonCompositedMainThreadScrollingReasons() &
+              reason);
+  ASSERT_FALSE(frameView->mainThreadScrollingReasons() & reason);
 
   // Remove clip path from descendant.
   element->removeAttribute(HTMLNames::styleAttr);
   forceFullCompositingUpdate();
+  ASSERT_FALSE(scrollableArea->getNonCompositedMainThreadScrollingReasons() &
+               reason);
   ASSERT_FALSE(frameView->mainThreadScrollingReasons() & reason);
 }
 
-TEST_P(StyleRelatedMainThreadScrollingReasonTest, DISABLED_LCDTextEnabledTest) {
+TEST_P(NonCompositedMainThreadScrollingReasonTest, LCDTextEnabledTest) {
   testStyle("transparent border-radius",
             MainThreadScrollingReason::kHasOpacityAndLCDText |
                 MainThreadScrollingReason::kHasBorderRadius);
 }
 
-TEST_P(StyleRelatedMainThreadScrollingReasonTest, DISABLED_BoxShadowTest) {
+TEST_P(NonCompositedMainThreadScrollingReasonTest, BoxShadowTest) {
   testStyle("box-shadow",
             MainThreadScrollingReason::kHasBoxShadowFromNonRootLayer);
 }
 

[bokan, 2017/04/06 21:45:10]

Please add a test to make sure that a style that would otherwise be
non-composited, wont have a NonCompositedScrollReason when will-change transform
is added. e.g.

.style {
  opacity: 0.5;
  will-change: transform;
}

Will composite so should not have a NonCompositing reason.

[yigu, 2017/04/07 16:35:32]

Done.

 }  // namespace blink