Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2773593005: Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (Closed)
Patch Set: Remove the UnknownNonCompositedRegion bucket Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 m_hadVerticalScrollbarBeforeRelayout = val; 474 m_hadVerticalScrollbarBeforeRelayout = val;
475 } 475 }
476 476
477 StickyConstraintsMap& stickyConstraintsMap() { 477 StickyConstraintsMap& stickyConstraintsMap() {
478 return ensureRareData().m_stickyConstraintsMap; 478 return ensureRareData().m_stickyConstraintsMap;
479 } 479 }
480 void invalidateAllStickyConstraints(); 480 void invalidateAllStickyConstraints();
481 void invalidateStickyConstraintsFor(PaintLayer*, 481 void invalidateStickyConstraintsFor(PaintLayer*,
482 bool needsCompositingUpdate = true); 482 bool needsCompositingUpdate = true);
483 483
484 void removeStyleRelatedMainThreadScrollingReasons(); 484 uint32_t getNonCompositedMainThreadScrollingReasons() {
485 void addStyleRelatedMainThreadScrollingReasons(const uint32_t); 485 return m_nonCompositedMainThreadScrollingReasons;
486 bool hasMainThreadScrollingReason(uint32_t reason) const {
487 return m_reasons & reason;
488 } 486 }
489 487
490 uint64_t id() const; 488 uint64_t id() const;
491 489
492 DECLARE_VIRTUAL_TRACE(); 490 DECLARE_VIRTUAL_TRACE();
493 491
494 private: 492 private:
495 explicit PaintLayerScrollableArea(PaintLayer&); 493 explicit PaintLayerScrollableArea(PaintLayer&);
496 494
497 bool hasHorizontalOverflow() const; 495 bool hasHorizontalOverflow() const;
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 LayoutScrollbarPart* m_scrollCorner; 586 LayoutScrollbarPart* m_scrollCorner;
589 587
590 // LayoutObject to hold our custom resizer. 588 // LayoutObject to hold our custom resizer.
591 LayoutScrollbarPart* m_resizer; 589 LayoutScrollbarPart* m_resizer;
592 590
593 ScrollAnchor m_scrollAnchor; 591 ScrollAnchor m_scrollAnchor;
594 592
595 std::unique_ptr<PaintLayerScrollableAreaRareData> m_rareData; 593 std::unique_ptr<PaintLayerScrollableAreaRareData> m_rareData;
596 594
597 // MainThreadScrollingReason due to the properties of the LayoutObject 595 // MainThreadScrollingReason due to the properties of the LayoutObject
598 uint32_t m_reasons; 596 uint32_t m_nonCompositedMainThreadScrollingReasons;
599 597
600 #if DCHECK_IS_ON() 598 #if DCHECK_IS_ON()
601 bool m_hasBeenDisposed; 599 bool m_hasBeenDisposed;
602 #endif 600 #endif
603 }; 601 };
604 602
605 DEFINE_TYPE_CASTS(PaintLayerScrollableArea, 603 DEFINE_TYPE_CASTS(PaintLayerScrollableArea,
606 ScrollableArea, 604 ScrollableArea,
607 scrollableArea, 605 scrollableArea,
608 scrollableArea->isPaintLayerScrollableArea(), 606 scrollableArea->isPaintLayerScrollableArea(),
609 scrollableArea.isPaintLayerScrollableArea()); 607 scrollableArea.isPaintLayerScrollableArea());
610 608
611 } // namespace blink 609 } // namespace blink
612 610
613 #endif // LayerScrollableArea_h 611 #endif // LayerScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698