Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2773593005: Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (Closed)
Patch Set: Update recording logic Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 776 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 // don't, both A and C should scroll on cc. Frame D should 787 // don't, both A and C should scroll on cc. Frame D should
788 // scrolled on main thread as its ancestor B. 788 // scrolled on main thread as its ancestor B.
789 void updateSubFrameScrollOnMainReason(const Frame&, 789 void updateSubFrameScrollOnMainReason(const Frame&,
790 MainThreadScrollingReasons); 790 MainThreadScrollingReasons);
791 String mainThreadScrollingReasonsAsText() const; 791 String mainThreadScrollingReasonsAsText() const;
792 // Main thread scrolling reasons including reasons from ancestors. 792 // Main thread scrolling reasons including reasons from ancestors.
793 MainThreadScrollingReasons mainThreadScrollingReasons() const; 793 MainThreadScrollingReasons mainThreadScrollingReasons() const;
794 // Main thread scrolling reasons for this object only. For all reasons, 794 // Main thread scrolling reasons for this object only. For all reasons,
795 // see: mainThreadScrollingReasons(). 795 // see: mainThreadScrollingReasons().
796 MainThreadScrollingReasons mainThreadScrollingReasonsPerFrame() const; 796 MainThreadScrollingReasons mainThreadScrollingReasonsPerFrame() const;
797 void adjustStyleRelatedMainThreadScrollingReasons(const uint32_t reason,
798 bool increase);
799 MainThreadScrollingReasons getStyleRelatedMainThreadScrollingReasons() const;
800 797
801 bool hasVisibleSlowRepaintViewportConstrainedObjects() const; 798 bool hasVisibleSlowRepaintViewportConstrainedObjects() const;
802 799
803 // Called on a view for a LocalFrame with a RemoteFrame parent. This makes 800 // Called on a view for a LocalFrame with a RemoteFrame parent. This makes
804 // viewport intersection available that accounts for remote ancestor frames 801 // viewport intersection available that accounts for remote ancestor frames
805 // and their respective scroll positions, clips, etc. 802 // and their respective scroll positions, clips, etc.
806 void setViewportIntersectionFromParent(const IntRect&); 803 void setViewportIntersectionFromParent(const IntRect&);
807 IntRect remoteViewportIntersection(); 804 IntRect remoteViewportIntersection();
808 805
809 // This method uses localToAncestorQuad to map a rect into an ancestor's 806 // This method uses localToAncestorQuad to map a rect into an ancestor's
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
1202 }; 1199 };
1203 std::unique_ptr<Vector<ObjectPaintInvalidation>> 1200 std::unique_ptr<Vector<ObjectPaintInvalidation>>
1204 m_trackedObjectPaintInvalidations; 1201 m_trackedObjectPaintInvalidations;
1205 1202
1206 // For Slimming Paint v2 only. 1203 // For Slimming Paint v2 only.
1207 std::unique_ptr<PaintController> m_paintController; 1204 std::unique_ptr<PaintController> m_paintController;
1208 std::unique_ptr<PaintArtifactCompositor> m_paintArtifactCompositor; 1205 std::unique_ptr<PaintArtifactCompositor> m_paintArtifactCompositor;
1209 1206
1210 bool m_isStoringCompositedLayerDebugInfo; 1207 bool m_isStoringCompositedLayerDebugInfo;
1211 MainThreadScrollingReasons m_mainThreadScrollingReasons; 1208 MainThreadScrollingReasons m_mainThreadScrollingReasons;
1212 // For recording main thread scrolling reasons
1213 // due to layout object properties. e.g. opacity, transform.
1214 // The size of the vector depends on the number of
1215 // main thread scrolling reasons.
1216 Vector<int> m_mainThreadScrollingReasonsCounter;
1217 1209
1218 // TODO(kenrb): Remove these when https://crbug.com/680606 is resolved. 1210 // TODO(kenrb): Remove these when https://crbug.com/680606 is resolved.
1219 std::unique_ptr<CompositorAnimationTimeline> m_animationTimeline; 1211 std::unique_ptr<CompositorAnimationTimeline> m_animationTimeline;
1220 std::unique_ptr<CompositorAnimationHost> m_animationHost; 1212 std::unique_ptr<CompositorAnimationHost> m_animationHost;
1221 1213
1222 Member<PrintContext> m_printContext; 1214 Member<PrintContext> m_printContext;
1223 1215
1224 FRIEND_TEST_ALL_PREFIXES(WebViewTest, DeviceEmulationResetScrollbars); 1216 FRIEND_TEST_ALL_PREFIXES(WebViewTest, DeviceEmulationResetScrollbars);
1225 }; 1217 };
1226 1218
(...skipping 28 matching lines...) Expand all
1255 frameViewBase.isFrameView()); 1247 frameViewBase.isFrameView());
1256 DEFINE_TYPE_CASTS(FrameView, 1248 DEFINE_TYPE_CASTS(FrameView,
1257 ScrollableArea, 1249 ScrollableArea,
1258 scrollableArea, 1250 scrollableArea,
1259 scrollableArea->isFrameView(), 1251 scrollableArea->isFrameView(),
1260 scrollableArea.isFrameView()); 1252 scrollableArea.isFrameView());
1261 1253
1262 } // namespace blink 1254 } // namespace blink
1263 1255
1264 #endif // FrameView_h 1256 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698