Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandlerTest.cpp

Issue 2773593005: Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (Closed)
Patch Set: bug fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/input/EventHandler.h" 5 #include "core/input/EventHandler.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/dom/Range.h" 9 #include "core/dom/Range.h"
10 #include "core/editing/Editor.h" 10 #include "core/editing/Editor.h"
11 #include "core/editing/FrameSelection.h" 11 #include "core/editing/FrameSelection.h"
12 #include "core/frame/FrameView.h" 12 #include "core/frame/FrameView.h"
13 #include "core/frame/LocalFrame.h" 13 #include "core/frame/LocalFrame.h"
14 #include "core/frame/Settings.h" 14 #include "core/frame/Settings.h"
15 #include "core/loader/EmptyClients.h" 15 #include "core/loader/EmptyClients.h"
16 #include "core/page/AutoscrollController.h" 16 #include "core/page/AutoscrollController.h"
17 #include "core/page/Page.h" 17 #include "core/page/Page.h"
18 #include "core/testing/DummyPageHolder.h" 18 #include "core/testing/DummyPageHolder.h"
19 #include "platform/testing/HistogramTester.h"
19 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
20 21
21 namespace blink { 22 namespace blink {
22 23
23 class EventHandlerTest : public ::testing::Test { 24 class EventHandlerTest : public ::testing::Test {
24 protected: 25 protected:
25 void SetUp() override; 26 void SetUp() override;
26 27
27 Page& page() const { return m_dummyPageHolder->page(); } 28 Page& page() const { return m_dummyPageHolder->page(); }
28 Document& document() const { return m_dummyPageHolder->document(); } 29 Document& document() const { return m_dummyPageHolder->document(); }
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 WebInputEvent::NoModifiers, 73 WebInputEvent::NoModifiers,
73 TimeTicks::Now().InSeconds()) { 74 TimeTicks::Now().InSeconds()) {
74 clickCount = clickCountParam; 75 clickCount = clickCountParam;
75 button = buttonParam; 76 button = buttonParam;
76 x = globalX = position.x(); 77 x = globalX = position.x();
77 y = globalY = position.y(); 78 y = globalY = position.y();
78 m_frameScale = 1; 79 m_frameScale = 1;
79 } 80 }
80 }; 81 };
81 82
83 class ScrollBeginEventBuilder : public WebGestureEvent {
84 public:
85 ScrollBeginEventBuilder(IntPoint position,
86 FloatPoint delta,
87 WebGestureDevice device)
88 : WebGestureEvent() {
89 m_type = WebInputEvent::GestureScrollBegin;
90 x = globalX = position.x();
91 y = globalY = position.y();
92 data.scrollBegin.deltaYHint = delta.y();
93 sourceDevice = device;
94 m_frameScale = 1;
95 }
96 };
97
98 class ScrollEndEventBuilder : public WebGestureEvent {
99 public:
100 ScrollEndEventBuilder() : WebGestureEvent() {
101 m_type = WebInputEvent::GestureScrollEnd;
102 m_frameScale = 1;
103 }
104 };
105
82 void EventHandlerTest::SetUp() { 106 void EventHandlerTest::SetUp() {
83 m_dummyPageHolder = DummyPageHolder::create(IntSize(300, 400)); 107 m_dummyPageHolder = DummyPageHolder::create(IntSize(300, 400));
84 } 108 }
85 109
86 void EventHandlerTest::setHtmlInnerHTML(const char* htmlContent) { 110 void EventHandlerTest::setHtmlInnerHTML(const char* htmlContent) {
87 document().documentElement()->setInnerHTML(String::fromUTF8(htmlContent)); 111 document().documentElement()->setInnerHTML(String::fromUTF8(htmlContent));
88 document().view()->updateAllLifecyclePhases(); 112 document().view()->updateAllLifecyclePhases();
89 } 113 }
90 114
91 TEST_F(EventHandlerTest, dragSelectionAfterScroll) { 115 TEST_F(EventHandlerTest, dragSelectionAfterScroll) {
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 WebInputEvent::MouseUp, WebFloatPoint(100, 50), WebFloatPoint(200, 250), 478 WebInputEvent::MouseUp, WebFloatPoint(100, 50), WebFloatPoint(200, 250),
455 WebPointerProperties::Button::Left, 1, WebInputEvent::NoModifiers, 479 WebPointerProperties::Button::Left, 1, WebInputEvent::NoModifiers,
456 TimeTicks::Now().InSeconds()); 480 TimeTicks::Now().InSeconds());
457 mouseUpEvent.setFrameScale(1); 481 mouseUpEvent.setFrameScale(1);
458 document().frame()->eventHandler().dragSourceEndedAt(mouseUpEvent, 482 document().frame()->eventHandler().dragSourceEndedAt(mouseUpEvent,
459 DragOperationNone); 483 DragOperationNone);
460 484
461 // This test passes if it doesn't crash. 485 // This test passes if it doesn't crash.
462 } 486 }
463 487
488 TEST_F(EventHandlerTest, NonCompositedMainThreadScrollingReasonTest) {
489 setHtmlInnerHTML(
490 "<style>.box { overflow:scroll; width: 100px; height: 100px; }"
491 " .translucent { opacity: 0.5; }"
492 " .spacer { height: 1000px; }"
493 " .composited { will-change: transform; }"
494 " .background_scroller { overflow: scroll; width: 250px; height: 250px;"
495 " position: absolute; z-index: -1;}"
496 " body { height: 2000px; width: 1000px; } "
497 "</style>"
498 "<div class='translucent box'><div class='spacer'></div></div>"
499 "<div id='under' class='background_scroller'>"
500 " <div class='spacer'></div>"
501 "</div>"
502 "<div class='composited box'>"
503 " <div class='spacer'></div>"
504 "</div>");
505
506 page().settings().setAcceleratedCompositingEnabled(true);
507 document().view()->setParentVisible(true);
508 document().view()->setSelfVisible(true);
509 document().view()->updateAllLifecyclePhases();
510
511 HistogramTester histogramTester;
512 // Test wheel scroll.
513 ScrollBeginEventBuilder wheelScrollBegin(
514 IntPoint(50, 50), FloatPoint(0.f, 1.f), WebGestureDeviceTouchpad);
515 ScrollEndEventBuilder wheelScrollEnd;
516 document().frame()->eventHandler().handleGestureEvent(wheelScrollBegin);
517 document().frame()->eventHandler().handleGestureEvent(wheelScrollEnd);
518 histogramTester.expectBucketCount("Renderer4.MainThreadWheelScrollReason", 17,
519 1);
520 histogramTester.expectBucketCount("Renderer4.MainThreadWheelScrollReason", 19,
521 1);
522
523 // Scroll a composited scroller A over a non-composited scroller B should
524 // cause the scroll events to go to the main thread because B is non fast
525 // scrollable region. If none of the scrollers from A's containing scroll
526 // chain has a reason, UnknownNonCompositedRegion should be added.
527 wheelScrollBegin.y = wheelScrollBegin.globalY = 150;
528 document().frame()->eventHandler().handleGestureEvent(wheelScrollBegin);
529 document().frame()->eventHandler().handleGestureEvent(wheelScrollEnd);
530 histogramTester.expectBucketCount("Renderer4.MainThreadWheelScrollReason", 23,
531 1);
532
533 // UnknownNonCompositedRegion is not added if the scroller underneath has a
534 // reason.
535 document().getElementById("under")->setAttribute("style", "position:fixed;");
536 document().frame()->eventHandler().handleGestureEvent(wheelScrollBegin);
537 document().frame()->eventHandler().handleGestureEvent(wheelScrollEnd);
538 histogramTester.expectBucketCount("Renderer4.MainThreadWheelScrollReason", 23,
539 1);
540 // Test touch scroll.
541 ScrollBeginEventBuilder touchScrollBegin(
542 IntPoint(50, 50), FloatPoint(0.f, 1.f), WebGestureDeviceTouchscreen);
543 ScrollEndEventBuilder touchScrollEnd;
544 document().frame()->eventHandler().handleGestureEvent(touchScrollBegin);
545 document().frame()->eventHandler().handleGestureEvent(touchScrollEnd);
546 histogramTester.expectBucketCount("Renderer4.MainThreadGestureScrollReason",
547 17, 1);
548
549 document().frame()->eventHandler().handleGestureEvent(touchScrollBegin);
550 document().frame()->eventHandler().handleGestureEvent(touchScrollEnd);
551 histogramTester.expectBucketCount("Renderer4.MainThreadGestureScrollReason",
552 17, 2);
553 }
554
464 class TooltipCapturingChromeClient : public EmptyChromeClient { 555 class TooltipCapturingChromeClient : public EmptyChromeClient {
465 public: 556 public:
466 TooltipCapturingChromeClient() {} 557 TooltipCapturingChromeClient() {}
467 558
468 void setToolTip(LocalFrame&, const String& str, TextDirection) override { 559 void setToolTip(LocalFrame&, const String& str, TextDirection) override {
469 m_lastToolTip = str; 560 m_lastToolTip = str;
470 } 561 }
471 562
472 String& lastToolTip() { return m_lastToolTip; } 563 String& lastToolTip() { return m_lastToolTip; }
473 564
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 WebInputEvent::MouseLeave, WebFloatPoint(0, 0), WebFloatPoint(0, 0), 605 WebInputEvent::MouseLeave, WebFloatPoint(0, 0), WebFloatPoint(0, 0),
515 WebPointerProperties::Button::NoButton, 0, WebInputEvent::NoModifiers, 606 WebPointerProperties::Button::NoButton, 0, WebInputEvent::NoModifiers,
516 TimeTicks::Now().InSeconds()); 607 TimeTicks::Now().InSeconds());
517 mouseLeaveEvent.setFrameScale(1); 608 mouseLeaveEvent.setFrameScale(1);
518 document().frame()->eventHandler().handleMouseLeaveEvent(mouseLeaveEvent); 609 document().frame()->eventHandler().handleMouseLeaveEvent(mouseLeaveEvent);
519 610
520 EXPECT_EQ(WTF::String(), lastToolTip()); 611 EXPECT_EQ(WTF::String(), lastToolTip());
521 } 612 }
522 613
523 } // namespace blink 614 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698