Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2773593005: Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (Closed)
Patch Set: bug fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 777 matching lines...) Expand 10 before | Expand all | Expand 10 after
788 // don't, both A and C should scroll on cc. Frame D should 788 // don't, both A and C should scroll on cc. Frame D should
789 // scrolled on main thread as its ancestor B. 789 // scrolled on main thread as its ancestor B.
790 void updateSubFrameScrollOnMainReason(const Frame&, 790 void updateSubFrameScrollOnMainReason(const Frame&,
791 MainThreadScrollingReasons); 791 MainThreadScrollingReasons);
792 String mainThreadScrollingReasonsAsText() const; 792 String mainThreadScrollingReasonsAsText() const;
793 // Main thread scrolling reasons including reasons from ancestors. 793 // Main thread scrolling reasons including reasons from ancestors.
794 MainThreadScrollingReasons mainThreadScrollingReasons() const; 794 MainThreadScrollingReasons mainThreadScrollingReasons() const;
795 // Main thread scrolling reasons for this object only. For all reasons, 795 // Main thread scrolling reasons for this object only. For all reasons,
796 // see: mainThreadScrollingReasons(). 796 // see: mainThreadScrollingReasons().
797 MainThreadScrollingReasons mainThreadScrollingReasonsPerFrame() const; 797 MainThreadScrollingReasons mainThreadScrollingReasonsPerFrame() const;
798 void adjustStyleRelatedMainThreadScrollingReasons(const uint32_t reason,
799 bool increase);
800 MainThreadScrollingReasons getStyleRelatedMainThreadScrollingReasons() const;
801 798
802 bool hasVisibleSlowRepaintViewportConstrainedObjects() const; 799 bool hasVisibleSlowRepaintViewportConstrainedObjects() const;
803 800
804 // Called on a view for a LocalFrame with a RemoteFrame parent. This makes 801 // Called on a view for a LocalFrame with a RemoteFrame parent. This makes
805 // viewport intersection available that accounts for remote ancestor frames 802 // viewport intersection available that accounts for remote ancestor frames
806 // and their respective scroll positions, clips, etc. 803 // and their respective scroll positions, clips, etc.
807 void setViewportIntersectionFromParent(const IntRect&); 804 void setViewportIntersectionFromParent(const IntRect&);
808 IntRect remoteViewportIntersection(); 805 IntRect remoteViewportIntersection();
809 806
810 // This method uses localToAncestorQuad to map a rect into an ancestor's 807 // This method uses localToAncestorQuad to map a rect into an ancestor's
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 }; 1203 };
1207 std::unique_ptr<Vector<ObjectPaintInvalidation>> 1204 std::unique_ptr<Vector<ObjectPaintInvalidation>>
1208 m_trackedObjectPaintInvalidations; 1205 m_trackedObjectPaintInvalidations;
1209 1206
1210 // For Slimming Paint v2 only. 1207 // For Slimming Paint v2 only.
1211 std::unique_ptr<PaintController> m_paintController; 1208 std::unique_ptr<PaintController> m_paintController;
1212 std::unique_ptr<PaintArtifactCompositor> m_paintArtifactCompositor; 1209 std::unique_ptr<PaintArtifactCompositor> m_paintArtifactCompositor;
1213 1210
1214 bool m_isStoringCompositedLayerDebugInfo; 1211 bool m_isStoringCompositedLayerDebugInfo;
1215 MainThreadScrollingReasons m_mainThreadScrollingReasons; 1212 MainThreadScrollingReasons m_mainThreadScrollingReasons;
1216 // For recording main thread scrolling reasons
1217 // due to layout object properties. e.g. opacity, transform.
1218 // The size of the vector depends on the number of
1219 // main thread scrolling reasons.
1220 Vector<int> m_mainThreadScrollingReasonsCounter;
1221 1213
1222 // TODO(kenrb): Remove these when https://crbug.com/680606 is resolved. 1214 // TODO(kenrb): Remove these when https://crbug.com/680606 is resolved.
1223 std::unique_ptr<CompositorAnimationTimeline> m_animationTimeline; 1215 std::unique_ptr<CompositorAnimationTimeline> m_animationTimeline;
1224 std::unique_ptr<CompositorAnimationHost> m_animationHost; 1216 std::unique_ptr<CompositorAnimationHost> m_animationHost;
1225 1217
1226 std::unique_ptr<GeometryMapper> m_geometryMapper; 1218 std::unique_ptr<GeometryMapper> m_geometryMapper;
1227 1219
1228 Member<PrintContext> m_printContext; 1220 Member<PrintContext> m_printContext;
1229 1221
1230 FRIEND_TEST_ALL_PREFIXES(WebViewTest, DeviceEmulationResetScrollbars); 1222 FRIEND_TEST_ALL_PREFIXES(WebViewTest, DeviceEmulationResetScrollbars);
(...skipping 30 matching lines...) Expand all
1261 frameViewBase.isFrameView()); 1253 frameViewBase.isFrameView());
1262 DEFINE_TYPE_CASTS(FrameView, 1254 DEFINE_TYPE_CASTS(FrameView,
1263 ScrollableArea, 1255 ScrollableArea,
1264 scrollableArea, 1256 scrollableArea,
1265 scrollableArea->isFrameView(), 1257 scrollableArea->isFrameView(),
1266 scrollableArea.isFrameView()); 1258 scrollableArea.isFrameView());
1267 1259
1268 } // namespace blink 1260 } // namespace blink
1269 1261
1270 #endif // FrameView_h 1262 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698