Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2773593005: Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (Closed)
Patch Set: Update recording logic for non composited reasons Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 781 matching lines...) Expand 10 before | Expand all | Expand 10 after
792 // don't, both A and C should scroll on cc. Frame D should 792 // don't, both A and C should scroll on cc. Frame D should
793 // scrolled on main thread as its ancestor B. 793 // scrolled on main thread as its ancestor B.
794 void updateSubFrameScrollOnMainReason(const Frame&, 794 void updateSubFrameScrollOnMainReason(const Frame&,
795 MainThreadScrollingReasons); 795 MainThreadScrollingReasons);
796 String mainThreadScrollingReasonsAsText() const; 796 String mainThreadScrollingReasonsAsText() const;
797 // Main thread scrolling reasons including reasons from ancestors. 797 // Main thread scrolling reasons including reasons from ancestors.
798 MainThreadScrollingReasons mainThreadScrollingReasons() const; 798 MainThreadScrollingReasons mainThreadScrollingReasons() const;
799 // Main thread scrolling reasons for this object only. For all reasons, 799 // Main thread scrolling reasons for this object only. For all reasons,
800 // see: mainThreadScrollingReasons(). 800 // see: mainThreadScrollingReasons().
801 MainThreadScrollingReasons mainThreadScrollingReasonsPerFrame() const; 801 MainThreadScrollingReasons mainThreadScrollingReasonsPerFrame() const;
802 void adjustStyleRelatedMainThreadScrollingReasons(const uint32_t reason,
803 bool increase);
804 MainThreadScrollingReasons getStyleRelatedMainThreadScrollingReasons() const;
805 802
806 bool hasVisibleSlowRepaintViewportConstrainedObjects() const; 803 bool hasVisibleSlowRepaintViewportConstrainedObjects() const;
807 804
808 // Called on a view for a LocalFrame with a RemoteFrame parent. This makes 805 // Called on a view for a LocalFrame with a RemoteFrame parent. This makes
809 // viewport intersection available that accounts for remote ancestor frames 806 // viewport intersection available that accounts for remote ancestor frames
810 // and their respective scroll positions, clips, etc. 807 // and their respective scroll positions, clips, etc.
811 void setViewportIntersectionFromParent(const IntRect&); 808 void setViewportIntersectionFromParent(const IntRect&);
812 IntRect remoteViewportIntersection(); 809 IntRect remoteViewportIntersection();
813 810
814 // This method uses localToAncestorQuad to map a rect into an ancestor's 811 // This method uses localToAncestorQuad to map a rect into an ancestor's
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
1211 }; 1208 };
1212 std::unique_ptr<Vector<ObjectPaintInvalidation>> 1209 std::unique_ptr<Vector<ObjectPaintInvalidation>>
1213 m_trackedObjectPaintInvalidations; 1210 m_trackedObjectPaintInvalidations;
1214 1211
1215 // For Slimming Paint v2 only. 1212 // For Slimming Paint v2 only.
1216 std::unique_ptr<PaintController> m_paintController; 1213 std::unique_ptr<PaintController> m_paintController;
1217 std::unique_ptr<PaintArtifactCompositor> m_paintArtifactCompositor; 1214 std::unique_ptr<PaintArtifactCompositor> m_paintArtifactCompositor;
1218 1215
1219 bool m_isStoringCompositedLayerDebugInfo; 1216 bool m_isStoringCompositedLayerDebugInfo;
1220 MainThreadScrollingReasons m_mainThreadScrollingReasons; 1217 MainThreadScrollingReasons m_mainThreadScrollingReasons;
1221 // For recording main thread scrolling reasons
1222 // due to layout object properties. e.g. opacity, transform.
1223 // The size of the vector depends on the number of
1224 // main thread scrolling reasons.
1225 Vector<int> m_mainThreadScrollingReasonsCounter;
1226 1218
1227 // TODO(kenrb): Remove these when https://crbug.com/680606 is resolved. 1219 // TODO(kenrb): Remove these when https://crbug.com/680606 is resolved.
1228 std::unique_ptr<CompositorAnimationTimeline> m_animationTimeline; 1220 std::unique_ptr<CompositorAnimationTimeline> m_animationTimeline;
1229 std::unique_ptr<CompositorAnimationHost> m_animationHost; 1221 std::unique_ptr<CompositorAnimationHost> m_animationHost;
1230 1222
1231 std::unique_ptr<GeometryMapper> m_geometryMapper; 1223 std::unique_ptr<GeometryMapper> m_geometryMapper;
1232 1224
1233 Member<PrintContext> m_printContext; 1225 Member<PrintContext> m_printContext;
1234 1226
1235 FRIEND_TEST_ALL_PREFIXES(WebViewTest, DeviceEmulationResetScrollbars); 1227 FRIEND_TEST_ALL_PREFIXES(WebViewTest, DeviceEmulationResetScrollbars);
(...skipping 30 matching lines...) Expand all
1266 frameViewBase.isFrameView()); 1258 frameViewBase.isFrameView());
1267 DEFINE_TYPE_CASTS(FrameView, 1259 DEFINE_TYPE_CASTS(FrameView,
1268 ScrollableArea, 1260 ScrollableArea,
1269 scrollableArea, 1261 scrollableArea,
1270 scrollableArea->isFrameView(), 1262 scrollableArea->isFrameView(),
1271 scrollableArea.isFrameView()); 1263 scrollableArea.isFrameView());
1272 1264
1273 } // namespace blink 1265 } // namespace blink
1274 1266
1275 #endif // FrameView_h 1267 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698