Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/FrameMenuSidebar.js

Issue 2773583002: [DevTools] Introduce a sidebar with a drop-down
Patch Set: [DevTools] Introduce a sidebar with a drop-down Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/FrameMenuSidebar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/FrameMenuSidebar.js b/third_party/WebKit/Source/devtools/front_end/resources/FrameMenuSidebar.js
new file mode 100644
index 0000000000000000000000000000000000000000..2bafcada4ae22f44e7a6b82cb974586906f5c804
--- /dev/null
+++ b/third_party/WebKit/Source/devtools/front_end/resources/FrameMenuSidebar.js
@@ -0,0 +1,38 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+Resources.FrameMenuSidebar = class extends UI.VBox {
+ constructor() {
+ super();
+
+ this.registerRequiredCSS('resources/frameMenuSidebar.css');
+
+ this._frameMenu = new Resources.FrameMenu();
+ this.contentElement.appendChild(this._frameMenu.element);
+ this._frameMenu.selectRootFrame();
+
+ SDK.targetManager.addModelListener(
+ SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.FrameDetached,
+ event => this._frameDetached(/** @type {!SDK.ResourceTreeFrame} */ (event.data)));
+ }
+
+ /**
+ * @param {!SDK.ResourceTreeFrame} frame
+ */
+ _frameDetached(frame) {
+ if (frame === this._frameMenu.selectedFrame())
+ this._frameMenu.selectRootFrame();
dgozman 2017/04/05 20:52:56 I'd move this logic to FrameMenu instead.
eostroukhov 2017/05/03 00:33:47 Done.
+ }
+
+ /**
+ * @param {!SDK.Resource} resource
+ * @param {number=} line
+ * @param {number=} column
+ * @return {boolean}
+ */
+ showResource(resource, line, column) {
+ // TODO (eostroukhov) Waiting till the resource tree is ported.
+ return true;
+ }
+};

Powered by Google App Engine
This is Rietveld 408576698