Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/resources/FrameMenuSidebar.js

Issue 2773583002: [DevTools] Introduce a sidebar with a drop-down
Patch Set: [DevTools] Introduce a sidebar with a drop-down Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 Resources.FrameMenuSidebar = class extends UI.VBox {
6 constructor() {
7 super();
8
9 this.registerRequiredCSS('resources/frameMenuSidebar.css');
10
11 this._frameMenu = new Resources.FrameMenu();
12 this.contentElement.appendChild(this._frameMenu.element);
13 this._frameMenu.selectRootFrame();
14
15 SDK.targetManager.addModelListener(
16 SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.FrameDetached,
17 event => this._frameDetached(/** @type {!SDK.ResourceTreeFrame} */ (even t.data)));
18 }
19
20 /**
21 * @param {!SDK.ResourceTreeFrame} frame
22 */
23 _frameDetached(frame) {
24 if (frame === this._frameMenu.selectedFrame())
25 this._frameMenu.selectRootFrame();
dgozman 2017/04/05 20:52:56 I'd move this logic to FrameMenu instead.
eostroukhov 2017/05/03 00:33:47 Done.
26 }
27
28 /**
29 * @param {!SDK.Resource} resource
30 * @param {number=} line
31 * @param {number=} column
32 * @return {boolean}
33 */
34 showResource(resource, line, column) {
35 // TODO (eostroukhov) Waiting till the resource tree is ported.
36 return true;
37 }
38 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698