window.open() should gate new tab/new popup based on toolbar visibility.

third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 69 matching lines @@
   void TearDown() override { m_webView->close(); }
 
   WebNavigationPolicy getNavigationPolicyWithMouseEvent(
       int modifiers,
       WebMouseEvent::Button button,
       bool asPopup) {
     WebMouseEvent event(WebInputEvent::MouseUp, modifiers,
                         WebInputEvent::TimeStampForTesting);
     event.button = button;
     setCurrentInputEventForTest(&event);
-    m_chromeClientImpl->setScrollbarsVisible(!asPopup);
+    m_chromeClientImpl->setToolbarsVisible(!asPopup);
     m_chromeClientImpl->show(NavigationPolicyIgnore);
     setCurrentInputEventForTest(0);
     return m_result;
   }
 
   bool isNavigationPolicyPopup() {
     m_chromeClientImpl->show(NavigationPolicyIgnore);
     return m_result == WebNavigationPolicyNewPopup;
   }
 
@@ skipping 103 matching lines @@
             getNavigationPolicyWithMouseEvent(modifiers, button, asPopup));
 }
 
 TEST_F(GetNavigationPolicyTest, NoToolbarsForcesPopup) {
   m_chromeClientImpl->setToolbarsVisible(false);
   EXPECT_TRUE(isNavigationPolicyPopup());
   m_chromeClientImpl->setToolbarsVisible(true);
   EXPECT_FALSE(isNavigationPolicyPopup());
 }
 
-TEST_F(GetNavigationPolicyTest, NoStatusbarForcesPopup) {
+TEST_F(GetNavigationPolicyTest, NoStatusbarIsNotPopup) {
   m_chromeClientImpl->setStatusbarVisible(false);
-  EXPECT_TRUE(isNavigationPolicyPopup());
+  EXPECT_FALSE(isNavigationPolicyPopup());
   m_chromeClientImpl->setStatusbarVisible(true);
   EXPECT_FALSE(isNavigationPolicyPopup());
 }
 
-TEST_F(GetNavigationPolicyTest, NoMenubarForcesPopup) {
+TEST_F(GetNavigationPolicyTest, NoMenubarIsNotPopup) {
   m_chromeClientImpl->setMenubarVisible(false);
-  EXPECT_TRUE(isNavigationPolicyPopup());
+  EXPECT_FALSE(isNavigationPolicyPopup());
   m_chromeClientImpl->setMenubarVisible(true);
   EXPECT_FALSE(isNavigationPolicyPopup());
 }
 
-TEST_F(GetNavigationPolicyTest, NotResizableForcesPopup) {
+TEST_F(GetNavigationPolicyTest, NotResizableIsNotPopup) {
   m_chromeClientImpl->setResizable(false);
-  EXPECT_TRUE(isNavigationPolicyPopup());
+  EXPECT_FALSE(isNavigationPolicyPopup());
   m_chromeClientImpl->setResizable(true);
   EXPECT_FALSE(isNavigationPolicyPopup());
 }
 
 class ViewCreatingClient : public FrameTestHelpers::TestWebViewClient {
  public:
   WebView* createView(WebLocalFrame* opener,
                       const WebURLRequest&,
                       const WebWindowFeatures&,
                       const WebString& name,
@@ skipping 30 matching lines @@
   ScopedPageSuspender suspender;
   LocalFrame* frame = toWebLocalFrameImpl(m_mainFrame)->frame();
   FrameLoadRequest request(frame->document());
   WindowFeatures features;
   EXPECT_EQ(nullptr,
             m_chromeClientImpl->createWindow(frame, request, features,
                                              NavigationPolicyNewForegroundTab));
 }
 
 }  // namespace blink