window.open() should gate new tab/new popup based on toolbar visibility.

third_party/WebKit/Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 313 matching lines @@
 
   // User and app agree that we want a new window; let the app override the
   // decorations.
   if (userPolicy == NavigationPolicyNewWindow &&
       *policy == NavigationPolicyNewPopup)
     return;
   *policy = userPolicy;
 }
 
 WebNavigationPolicy getNavigationPolicy(const WindowFeatures& features) {
-  // If our default configuration was modified by a script or wasn't
-  // created by a user gesture, then show as a popup. Else, let this
-  // new window be opened as a toplevel window.
-  bool asPopup = !features.toolBarVisible || !features.statusBarVisible ||
-                 !features.scrollbarsVisible || !features.menuBarVisible ||
-                 !features.resizable;
+  // If the window features didn't enable the toolbar, or this window wasn't
+  // created by a user gesture, show as a popup instead of a new tab.
+  //
+  // Note: this previously also checked that menubar, resizable, scrollbar, and
+  // statusbar are enabled too. When no feature string is specified, these
+  // features default to enabled (and the window opens as a new tab). However,
+  // when a feature string is specified, any *unspecified* features default to
+  // disabled, often causing the window to open as a popup instead.
+  //
+  // As specifying menubar, resizable, scrollbar, and statusbar have no effect
+  // on the UI, just ignore them and only consider whether or not the toolbar is
+  // enabled, which matches Firefox's behavior.
+  bool asPopup = !features.toolBarVisible;
 
   NavigationPolicy policy = NavigationPolicyNewForegroundTab;
   if (asPopup)
     policy = NavigationPolicyNewPopup;
   updatePolicyForEvent(WebViewImpl::currentInputEvent(), &policy);
 
   return static_cast<WebNavigationPolicy>(policy);
 }
 
 WebNavigationPolicy effectiveNavigationPolicy(NavigationPolicy navigationPolicy,
@@ skipping 873 matching lines @@
     PresentationController::provideTo(frame, client->presentationClient());
   if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
     provideAudioOutputDeviceClientTo(frame,
                                      new AudioOutputDeviceClientImpl(frame));
   }
   if (RuntimeEnabledFeatures::installedAppEnabled())
     InstalledAppController::provideTo(frame, client->relatedAppsFetcher());
 }
 
 }  // namespace blink