Use asynchronized api for file system request. [blink] (3/4)

Source/modules/filesystem/LocalFileSystem.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 #include "core/dom/CrossThreadTask.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/fileapi/FileError.h"
 #include "core/inspector/InspectorController.h"
 #include "core/workers/WorkerGlobalScope.h"
 #include "modules/filesystem/FileSystemClient.h"
 #include "modules/filesystem/InspectorFileSystemAgent.h"
 #include "platform/AsyncFileSystemCallbacks.h"
+#include "platform/PermissionCallbacks.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebFileSystem.h"
+#include "wtf/Functional.h"
 
 namespace WebCore {
 
 namespace {
 
 void fileSystemNotAllowed(ExecutionContext*, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
 {
     callbacks->didFail(FileError::ABORT_ERR);
 }
 
 } // namespace
 
 PassOwnPtrWillBeRawPtr<LocalFileSystem> LocalFileSystem::create(PassOwnPtr<FileSystemClient> client)
 {
     return adoptPtrWillBeNoop(new LocalFileSystem(client));
 }
 
 LocalFileSystem::~LocalFileSystem()
 {
 }
 
-void LocalFileSystem::resolveURL(ExecutionContext* context, const KURL& fileSystemURL, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
+void LocalFileSystem::resolveURL(PassRefPtr<ExecutionContext> context, const KURL& fileSystemURL, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
 {
-    if (!client() || !client()->allowFileSystem(context)) {
-        context->postTask(createCallbackTask(&fileSystemNotAllowed, callbacks));
+    RefPtr<ExecutionContext> contextPtr = context;
+    if (!client()) {
+        fileSystemNotAllowedInternal(contextPtr, callbacks);
         return;
     }
-    blink::Platform::current()->fileSystem()->resolveURL(fileSystemURL, callbacks);
+    ASSERT(contextPtr);
+    if (!contextPtr->isDocument()) {
+        if (!client()->requestFileSystemAccessSync(contextPtr.get())) {
+            fileSystemNotAllowedInternal(contextPtr, callbacks);
+            return;
+        }
+        resolveURLInternal(fileSystemURL, callbacks);
+        return;
+    }
+    client()->requestFileSystemAccessAsync(contextPtr.get(), PermissionCallbacks::create(
+        bind(&LocalFileSystem::resolveURLInternal, this, fileSystemURL, callbacks),
+        bind(&LocalFileSystem::fileSystemNotAllowedInternal, this, contextPtr, callbacks)));

[kinuko, 2014/05/19 09:02:46]

I think these patterns can be probably implemented using common internal method
which takes ExecutionContext and two closures (for allow and denied cases).

[Xi Han, 2014/05/20 16:13:32]

Done.

 }
 
-void LocalFileSystem::requestFileSystem(ExecutionContext* context, FileSystemType type, long long size, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
+void LocalFileSystem::requestFileSystem(PassRefPtr<ExecutionContext> context, FileSystemType type, long long size, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
 {
-    if (!client() || !client()->allowFileSystem(context)) {
-        context->postTask(createCallbackTask(&fileSystemNotAllowed, callbacks));
+    RefPtr<ExecutionContext> contextPtr = context;
+    if (!client()) {
+        fileSystemNotAllowedInternal(contextPtr, callbacks);
         return;
     }
+    ASSERT(contextPtr);
+    if (!contextPtr->isDocument()) {
+        if (!client()->requestFileSystemAccessSync(contextPtr.get())) {
+            fileSystemNotAllowedInternal(contextPtr, callbacks);
+            return;
+        }
+        fileSystemAllowedInternal(contextPtr, type, callbacks);
+        return;
+    }
+    client()->requestFileSystemAccessAsync(contextPtr.get(), PermissionCallbacks::create(
+        bind(&LocalFileSystem::fileSystemAllowedInternal, this, contextPtr, type, callbacks),
+        bind(&LocalFileSystem::fileSystemNotAllowedInternal, this, contextPtr, callbacks)));
+}
+
+void LocalFileSystem::deleteFileSystem(PassRefPtr<ExecutionContext> context, FileSystemType type, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
+{
+    RefPtr<ExecutionContext> contextPtr = context;
+    ASSERT(contextPtr);
+    ASSERT_WITH_SECURITY_IMPLICATION(contextPtr->isDocument());
+    if (!client()) {
+        fileSystemNotAllowedInternal(contextPtr, callbacks);
+        return;
+    }
+    client()->requestFileSystemAccessAsync(contextPtr.get(), PermissionCallbacks::create(
+        bind(&LocalFileSystem::deleteFileSystemInternal, this, contextPtr, type, callbacks),
+        bind(&LocalFileSystem::fileSystemNotAllowedInternal, this, contextPtr, callbacks)));
+}
+
+void LocalFileSystem::fileSystemNotAllowedInternal(
+    PassRefPtr<ExecutionContext> context,
+    PassOwnPtr<AsyncFileSystemCallbacks> callbacks) {
+    context->postTask(createCallbackTask(&fileSystemNotAllowed, callbacks));
+}
+
+void LocalFileSystem::fileSystemAllowedInternal(
+    PassRefPtr<ExecutionContext> context,
+    FileSystemType type,
+    PassOwnPtr<AsyncFileSystemCallbacks> callbacks) {
     KURL storagePartition = KURL(KURL(), context->securityOrigin()->toString());
     blink::Platform::current()->fileSystem()->openFileSystem(storagePartition, static_cast<blink::WebFileSystemType>(type), callbacks);
 }
 
-void LocalFileSystem::deleteFileSystem(ExecutionContext* context, FileSystemType type, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
-{
-    ASSERT(context);
-    ASSERT_WITH_SECURITY_IMPLICATION(context->isDocument());
+void LocalFileSystem::resolveURLInternal(
+    const KURL& fileSystemURL,
+    PassOwnPtr<AsyncFileSystemCallbacks> callbacks) {
+    blink::Platform::current()->fileSystem()->resolveURL(fileSystemURL, callbacks);
+}
 
-    if (!client() || !client()->allowFileSystem(context)) {
-        context->postTask(createCallbackTask(&fileSystemNotAllowed, callbacks));
-        return;
-    }
+void LocalFileSystem::deleteFileSystemInternal(
+    PassRefPtr<ExecutionContext> context,
+    FileSystemType type,
+    PassOwnPtr<AsyncFileSystemCallbacks> callbacks) {
     KURL storagePartition = KURL(KURL(), context->securityOrigin()->toString());
     blink::Platform::current()->fileSystem()->deleteFileSystem(storagePartition, static_cast<blink::WebFileSystemType>(type), callbacks);
 }
 
 LocalFileSystem::LocalFileSystem(PassOwnPtr<FileSystemClient> client)
     : m_client(client)
 {
 }
 
 const char* LocalFileSystem::supplementName()
@@ skipping 15 matching lines @@
     page.provideSupplement(LocalFileSystem::supplementName(), LocalFileSystem::create(client));
     page.inspectorController().registerModuleAgent(InspectorFileSystemAgent::create(&page));
 }
 
 void provideLocalFileSystemToWorker(WorkerClients* clients, PassOwnPtr<FileSystemClient> client)
 {
     clients->provideSupplement(LocalFileSystem::supplementName(), LocalFileSystem::create(client));
 }
 
 } // namespace WebCore