Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2509)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 2773483003: Create PasswordProtectionRequest to handle password pings (Closed)
Patch Set: Address lpz's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/safe_browsing/password_protection/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index e34d9d9c323e7baca55792874f4fd5fd66567d6a..161de9307167c5d165c0b0104a32ebce58e7da74 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -334,8 +334,8 @@ void SafeBrowsingService::Initialize() {
// TODO(jialiul): When PasswordProtectionService does more than reporting UMA,
// we need to add finch trial to gate its functionality.
- password_protection_service_ =
- base::MakeUnique<PasswordProtectionService>(database_manager());
+ password_protection_service_ = base::MakeUnique<PasswordProtectionService>(
+ database_manager(), url_request_context());
// Track the safe browsing preference of existing profiles.
// The SafeBrowsingService will be started if any existing profile has the
@@ -376,6 +376,8 @@ void SafeBrowsingService::ShutDown() {
Stop(true);
+ password_protection_service_.reset();
+
services_delegate_->ShutdownServices();
// Since URLRequestContextGetters are refcounted, can't count on clearing
« no previous file with comments | « no previous file | components/safe_browsing/password_protection/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698