DescriptionFix block offset used by absolute-positioned objects
Absolute-positioned objects can be positioned as static
if top/bottom is auto. That's why they need to know
their block offset that composes from content_size and current
MarginStrut.
List of changes:
1) Set the correct block offset for absolute-positioned objects
2) Do not reset text child's margin as we need them to set
MarginStrut properly.
3) Move ComputeMinMaxContentSize and Style methods definition to
the base class and make them to be pure virtual methods.
4) Change CalculateMargins to work with NGLayoutInputNode base class
5) Update TestExpectations
BUG=635619
TEST=virtual/layout_ng/fast/block/margin-collapse/002.html and others
Review-Url: https://codereview.chromium.org/2773453004
Cr-Commit-Position: refs/heads/master@{#459499}
Committed: https://chromium.googlesource.com/chromium/src/+/6d8a607a3ba62cbd82d8ada7b10ad5c1ef5c978c
Patch Set 1 #
Total comments: 5
Patch Set 2 : add DCHECK #Patch Set 3 : git rebase-update #Patch Set 4 : git rebase-update #Messages
Total messages: 41 (33 generated)
|