Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3893)

Unified Diff: chromecast/app/BUILD.gn

Issue 2773453003: [Chromecast] Remove chromecast_repack_locales.py. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/app/BUILD.gn
diff --git a/chromecast/app/BUILD.gn b/chromecast/app/BUILD.gn
index 84c88cfb5f61402ed5df426b2a7c99b669a62228..4aed5e684f3786b6a82251351dc0a3a72fcf6569 100644
--- a/chromecast/app/BUILD.gn
+++ b/chromecast/app/BUILD.gn
@@ -105,13 +105,6 @@ grit("chromecast_settings") {
source = "//chromecast/app/resources/chromecast_settings.grd"
resource_ids = "//chromecast/app/resources/resource_ids"
- # TODO(thakis): Consider removing output_dir in favor of the default
- # directory, then it becomes possible to qualify includes of
- # grit/chromecast_settings.h and DEPS files work better too.
- # https://crbug.com/697090
- output_dir = "$root_gen_dir/chromecast_strings"
- use_qualified_include = false
-
outputs = [
mbjorge 2017/03/22 21:26:33 should this be based on the |locales| array of suf
slan 2017/03/22 22:54:52 Great idea! Done.
"grit/chromecast_settings.h",
"chromecast_settings_am.pak",
« chromecast/BUILD.gn ('K') | « chromecast/BUILD.gn ('k') | chromecast/browser/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698