Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: components/autofill/core/browser/form_structure.cc

Issue 2773433002: Log observations of explicit UPI-VPA autocomplete hints. (Closed)
Patch Set: Initial CL Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_structure.cc
diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc
index 02e861fe9c2a9a7076100f8dc5cd20968a3c1d6b..b15f45457c7808d235361ab85b46211b11767cd1 100644
--- a/components/autofill/core/browser/form_structure.cc
+++ b/components/autofill/core/browser/form_structure.cc
@@ -268,6 +268,12 @@ HtmlFieldType FieldTypeFromAutocompleteAttributeValue(
if (autocomplete_attribute_value == "email")
return HTML_TYPE_EMAIL;
+ if (autocomplete_attribute_value == "upi-vpa") {
+ // TODO(rogerm): Add UPI_VIRTUAL_PAYMENT_ADDRESS as an autofill type.
Mathieu 2017/03/23 11:26:22 TODO(crbug.com/xxxxxx) is the norm now (more tract
Mathieu 2017/03/23 11:26:22 nit: it would be HTML_TYPE_UPI...
Roger McFarlane (Chromium) 2017/03/28 19:08:23 Done.
Roger McFarlane (Chromium) 2017/03/28 19:08:24 Done.
+ // Until then, fall through after logging the observation.
+ AutofillMetrics::LogExplicitUpiVpaHint();
+ }
+
return HTML_TYPE_UNRECOGNIZED;
}

Powered by Google App Engine
This is Rietveld 408576698