chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h - Issue 2773383002: [Payments] In shipping address editor, enable required + phone validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

Issue 2773383002: [Payments] In shipping address editor, enable required + phone validation. (Closed)

Patch Set: clear error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

diff --git a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

index ba014a4edd99d9e1ae5226a8b60df2fb98956bc5..a2c7cde2da858ce950d9b36bebf6eff85bf8126f 100644

--- a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

+++ b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

@@ -58,8 +58,7 @@ class ShippingAddressEditorViewController : public EditorViewController {

bool ValidateValue(const base::string16& value);

EditorField field_;

- // TODO(mad): Bring back when needed.

- // ShippingAddressEditorViewController* parent_{nullptr};

+ ShippingAddressEditorViewController* controller_;

anthonyvd 2017/03/27 14:05:08 nit: comment about why the raw pointer is OK?

Mathieu 2017/03/27 16:36:11 Done.

DISALLOW_COPY_AND_ASSIGN(ShippingAddressValidationDelegate);

};

« no previous file with comments | « no previous file | chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc » ('j') | no next file with comments »