chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc - Issue 2773353002: Make minimum PWA icon size the same accross all device densities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

Issue 2773353002: Make minimum PWA icon size the same accross all device densities

Patch Set: Merge branch 'master' into min_size Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_manager.cc » ('j') | chrome/browser/installable/installable_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

index df56a43677e174441786283a5e50241bc5f869fb..04d0ee5f2b330efbbe9e2fefe6d2312f9418ea65 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

@@ -207,7 +207,7 @@ class AddToHomescreenDataFetcherTest : public ChromeRenderViewHostTestHarness {

scoped_refptr<AddToHomescreenDataFetcher> BuildFetcher(

bool check_webapk_compatible,

AddToHomescreenDataFetcher::Observer* observer) {

- return new AddToHomescreenDataFetcher(web_contents(), 1, 1, 1, 1, 1,

+ return new AddToHomescreenDataFetcher(web_contents(), 144, 144, 24,

Xi Han 2017/04/03 18:24:58 May I know why to change the third parameter? Is t

pkotwicz 2017/04/05 04:29:07 Reverted 24 to 1

pkotwicz 2017/04/05 14:59:34 Done for real now

check_webapk_compatible, observer);

}