Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2773353002: Make minimum PWA icon size the same accross all device densities
Patch Set: Merge branch 'master' into min_size Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index a6d0f74cde0760acc9a47f841344ba24f87639af..a5dbe1ca438aacc0d17aff5fc17b8147c8f4c202 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -50,11 +50,9 @@ std::unique_ptr<ShortcutInfo> CreateShortcutInfo(
shortcut_info->ideal_splash_image_size_in_px =
ShortcutHelper::GetIdealSplashImageSizeInPx();
- shortcut_info->minimum_splash_image_size_in_px =
- ShortcutHelper::GetMinimumSplashImageSizeInPx();
shortcut_info->splash_image_url = ManifestIconSelector::FindBestMatchingIcon(
manifest.icons, shortcut_info->ideal_splash_image_size_in_px,
- shortcut_info->minimum_splash_image_size_in_px,
+ InstallableManager::GetMinimumIconSizeInPx(),
content::Manifest::Icon::IconPurpose::ANY);
return shortcut_info;
@@ -105,7 +103,7 @@ bool AppBannerManagerAndroid::OnAppDetailsRetrieved(
return ManifestIconDownloader::Download(
web_contents(), primary_icon_url_, GetIdealPrimaryIconSizeInPx(),
- GetMinimumPrimaryIconSizeInPx(),
+ InstallableManager::GetMinimumIconSizeInPx(),
base::Bind(&AppBannerManager::OnAppIconFetched, GetWeakPtr()));
}
@@ -136,10 +134,6 @@ int AppBannerManagerAndroid::GetIdealPrimaryIconSizeInPx() {
return ShortcutHelper::GetIdealHomescreenIconSizeInPx();
}
-int AppBannerManagerAndroid::GetMinimumPrimaryIconSizeInPx() {
- return ShortcutHelper::GetMinimumHomescreenIconSizeInPx();
-}
-
bool AppBannerManagerAndroid::IsWebAppInstalled(
content::BrowserContext* browser_context,
const GURL& start_url,
@@ -160,7 +154,6 @@ InstallableParams AppBannerManagerAndroid::ParamsToPerformInstallableCheck() {
if (can_install_webapk_) {
params.ideal_badge_icon_size_in_px = GetIdealBadgeIconSizeInPx();
- params.minimum_badge_icon_size_in_px = GetIdealBadgeIconSizeInPx();
params.fetch_valid_badge_icon = true;
}

Powered by Google App Engine
This is Rietveld 408576698