Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/banners/app_banner_manager.h

Issue 2773353002: Make minimum PWA icon size the same accross all device densities
Patch Set: Merge branch 'master' into min_size Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_ 5 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
6 #define CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_ 6 #define CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 // Return a string describing what type of banner is being created. Used when 108 // Return a string describing what type of banner is being created. Used when
109 // alerting websites that a banner is about to be created. 109 // alerting websites that a banner is about to be created.
110 virtual std::string GetBannerType(); 110 virtual std::string GetBannerType();
111 111
112 // Returns a string parameter for a devtools console message corresponding to 112 // Returns a string parameter for a devtools console message corresponding to
113 // |code|. Returns the empty string if |code| requires no parameter. 113 // |code|. Returns the empty string if |code| requires no parameter.
114 std::string GetStatusParam(InstallableStatusCode code); 114 std::string GetStatusParam(InstallableStatusCode code);
115 115
116 // Returns the ideal and minimum primary icon size requirements. 116 // Returns the ideal and minimum primary icon size requirements.
117 virtual int GetIdealPrimaryIconSizeInPx(); 117 virtual int GetIdealPrimaryIconSizeInPx();
118 virtual int GetMinimumPrimaryIconSizeInPx();
119 118
120 // Returns a WeakPtr to this object. Exposed so subclasses/infobars may 119 // Returns a WeakPtr to this object. Exposed so subclasses/infobars may
121 // may bind callbacks without needing their own WeakPtrFactory. 120 // may bind callbacks without needing their own WeakPtrFactory.
122 base::WeakPtr<AppBannerManager> GetWeakPtr(); 121 base::WeakPtr<AppBannerManager> GetWeakPtr();
123 122
124 // Returns true if |is_debug_mode_| is true or the 123 // Returns true if |is_debug_mode_| is true or the
125 // kBypassAppBannerEngagementChecks flag is set. 124 // kBypassAppBannerEngagementChecks flag is set.
126 virtual bool IsDebugMode() const; 125 virtual bool IsDebugMode() const;
127 126
128 // Returns true if the webapp at |start_url| has already been installed. 127 // Returns true if the webapp at |start_url| has already been installed.
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 // scoped to the WebContents which they are observing. This allows us to use 276 // scoped to the WebContents which they are observing. This allows us to use
278 // weak pointers for callbacks. 277 // weak pointers for callbacks.
279 base::WeakPtrFactory<AppBannerManager> weak_factory_; 278 base::WeakPtrFactory<AppBannerManager> weak_factory_;
280 279
281 DISALLOW_COPY_AND_ASSIGN(AppBannerManager); 280 DISALLOW_COPY_AND_ASSIGN(AppBannerManager);
282 }; 281 };
283 282
284 } // namespace banners 283 } // namespace banners
285 284
286 #endif // CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_ 285 #endif // CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698