chrome/browser/android/offline_pages/recent_tab_helper.h - Issue 2773273002: Last_n: do not save snapshot of custom tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.h

Issue 2773273002: Last_n: do not save snapshot of custom tabs. (Closed)

Patch Set: Renamed method; added custom tab checks to tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/offline_pages/recent_tab_helper.h

diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.h b/chrome/browser/android/offline_pages/recent_tab_helper.h

index 3e96a7e0d00fbd93c8584fb1de802abca844d597..b5472401b6f950036af7fbe5ee1df5eb4f20ef8c 100644

--- a/chrome/browser/android/offline_pages/recent_tab_helper.h

+++ b/chrome/browser/android/offline_pages/recent_tab_helper.h

@@ -59,6 +59,7 @@ class RecentTabHelper

// There is no expectations that tab_id is always present.

virtual bool GetTabId(content::WebContents* web_contents, int* tab_id) = 0;

virtual bool IsLowEndDevice() = 0;

+ virtual bool IsCustomTab(content::WebContents* web_contents) = 0;

};

void SetDelegate(std::unique_ptr<RecentTabHelper::Delegate> delegate);