Last_n: do not save snapshot of custom tabs.

chrome/browser/android/offline_pages/recent_tab_helper.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/recent_tab_helper.h"
 
 #include <queue>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 31 matching lines @@
   std::unique_ptr<offline_pages::OfflinePageArchiver> CreatePageArchiver(
       content::WebContents* web_contents) override {
     return base::MakeUnique<offline_pages::OfflinePageMHTMLArchiver>(
         web_contents);
   }
   bool GetTabId(content::WebContents* web_contents, int* tab_id) override {
     return offline_pages::OfflinePageUtils::GetTabId(web_contents, tab_id);
   }
   bool IsLowEndDevice() override { return is_low_end_device_; }
 
+  bool IsCustomTab(content::WebContents* web_contents) override {
+    return offline_pages::OfflinePageUtils::CurrentlyShownInCustomTab(
+        web_contents);
+  }
+
  private:
   // Cached value of whether low end device.
   bool is_low_end_device_;
 };
 }  // namespace
 
 namespace offline_pages {
 
 using PageQuality = SnapshotController::PageQuality;
 
@@ skipping 56 matching lines @@
              << web_contents()->GetLastCommittedURL().spec();
     ReportDownloadStatusToRequestCoordinator(new_downloads_snapshot_info.get(),
                                              false);
     return;
   }
 
   // If there is an ongoing snapshot request, completely ignore this one and
   // cancel the Background Offliner request.
   // TODO(carlosk): it might be better to make the decision to schedule or not
   // the background request here. See https://crbug.com/686165.
-  // TODO(carlosk): there is an edge case that happens when the ongoing request
-  // was automatically and transparently scheduled by a navigation event and
-  // this call happens due to the user pressing the download button. The user's
-  // request to download the page will be immediately dismissed. See
-  // https://crbug.com/686283.
   if (downloads_ongoing_snapshot_info_) {
     DVLOG(1) << "Ongoing request exist; ignored download request for: "
              << web_contents()->GetLastCommittedURL().spec();
     ReportDownloadStatusToRequestCoordinator(new_downloads_snapshot_info.get(),
                                              true);
     return;
   }
 
   // Stores the new snapshot info.
   downloads_ongoing_snapshot_info_ = std::move(new_downloads_snapshot_info);
@@ skipping 116 matching lines @@
         downloads_ongoing_snapshot_info_.get(), false);
   }
   // And cancel any ongoing snapshots.
   CancelInFlightSnapshots();
 }
 
 void RecentTabHelper::WasHidden() {
   if (!IsOffliningRecentPagesEnabled())
     return;
 
-  // Return immediately if last_n is not listening to tab hidden events, if a
-  // last_n snapshot is currently being saved or if the tab is closing.
+  // Do not save a snapshots if any of these are true:
+  // - Last_n is not listening to tab hidden events.
+  // - A last_n snapshot is currently being saved.
+  // - The tab is in the process of being closed.
+  // - The tab is currently presented as a custom tab.
   if (!last_n_listen_to_tab_hidden_ || last_n_ongoing_snapshot_info_ ||
-      tab_is_closing_) {
+      tab_is_closing_ || delegate_->IsCustomTab(web_contents())) {
     DVLOG(1) << "Will not snapshot for last_n (reasons: "
              << !last_n_listen_to_tab_hidden_ << ", "
              << !!last_n_ongoing_snapshot_info_ << ", " << tab_is_closing_
+             << ", " << delegate_->IsCustomTab(web_contents())
              << ") for: " << web_contents()->GetLastCommittedURL().spec();
     return;
   }
 
   // Do not save if page quality is too low.
   // Note: we assume page quality for a page can only increase.
   if (snapshot_controller_->current_page_quality() == PageQuality::POOR) {
     DVLOG(1) << "Will not snapshot for last_n (page quality too low) for: "
              << web_contents()->GetLastCommittedURL().spec();
     return;
@@ skipping 191 matching lines @@
 }
 
 void RecentTabHelper::CancelInFlightSnapshots() {
   weak_ptr_factory_.InvalidateWeakPtrs();
   downloads_ongoing_snapshot_info_.reset();
   downloads_latest_saved_snapshot_info_.reset();
   last_n_ongoing_snapshot_info_.reset();
 }
 
 }  // namespace offline_pages