Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4541)

Unified Diff: chrome/test/data/webui/settings/appearance_page_test.js

Issue 2773233002: MD Settings: change settings-input to home-url-input due to reduced usage. (Closed)
Patch Set: fixed test that stopped working after code was updated per comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/appearance_page_test.js
diff --git a/chrome/test/data/webui/settings/appearance_page_test.js b/chrome/test/data/webui/settings/appearance_page_test.js
index 3beb0a747e40463d643ec7c1e70a7cb71d577c97..973578d31ff645657f9ab81398160e4199368373 100644
--- a/chrome/test/data/webui/settings/appearance_page_test.js
+++ b/chrome/test/data/webui/settings/appearance_page_test.js
@@ -252,21 +252,19 @@ suite('AppearanceHandler', function() {
});
test('home button urls', function() {
- appearancePage.set('prefs', {
- browser: {show_home_button: {value: true}},
- homepage: {type: chrome.settingsPrivate.PrefType.URL, value: 'test'}
- });
+ var input = document.createElement('home-url-input');
+ input.set(
+ 'pref', {type: chrome.settingsPrivate.PrefType.URL, value: 'test'});
+ document.body.appendChild(input);
dpapad 2017/03/30 20:27:00 This test no longer uses appearancePage. Let's cal
scottchen 2017/03/31 00:01:06 Done.
Polymer.dom.flush();
- var input = appearancePage.$$('#customHomePage');
- assertTrue(!!input);
assertFalse(input.invalid);
assertEquals(input.value, 'test');
input.value = '@@@';
appearanceBrowserProxy.setValidStartupPageResponse(false);
- input.fire('input');
+ input.$.input.fire('input');
return appearanceBrowserProxy.whenCalled('validateStartupPage')
.then(function() {
@@ -275,7 +273,7 @@ suite('AppearanceHandler', function() {
assertTrue(input.invalid);
// Should reset to default value on change event.
- input.$$('paper-input').fire('change');
+ input.$.input.fire('change');
Polymer.dom.flush();
assertEquals(input.value, 'test');
});
« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698