Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 2773233002: MD Settings: change settings-input to home-url-input due to reduced usage. (Closed)
Patch Set: move no-extension-indicator flag Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.html
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html
index bdc12b124a63d14fc328577ab3c66731c106f6f7..d8cc62f22abd898a6f059b931d1786bd88f26909 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html
@@ -9,7 +9,6 @@
<link rel="import" href="../controls/controlled_radio_button.html">
<link rel="import" href="../controls/extension_controlled_indicator.html">
<link rel="import" href="../controls/settings_dropdown_menu.html">
-<link rel="import" href="../controls/settings_input.html">
<link rel="import" href="../controls/settings_radio_group.html">
<link rel="import" href="../controls/settings_toggle_button.html">
<link rel="import" href="../route.html">
@@ -17,6 +16,7 @@
<link rel="import" href="../settings_page/settings_subpage.html">
<link rel="import" href="../settings_shared_css.html">
<link rel="import" href="../settings_vars_css.html">
+<link rel="import" href="home_url_input.html">
dpapad 2017/03/28 00:09:27 Nit (optional) Move this one line below to keep al
scottchen 2017/03/30 07:05:03 Done.
<link rel="import" href="appearance_fonts_page.html">
<dom-module id="settings-appearance-page">
@@ -124,13 +124,9 @@
<!-- TODO(dbeam): this can show double indicators when both
homepage and whether to use the NTP as the homepage are
managed. -->
- <settings-input id="customHomePage" pref="{{prefs.homepage}}"
- label="$i18n{enterCustomWebAddress}"
- can-tab="[[!prefs.homepage_is_newtabpage.value]]"
- no-extension-indicator
- error-message="$i18n{notValid}"
- on-input="validate_" invalid="{{isHomeUrlInvalid_}}">
- </settings-input>
+ <home-url-input id="customHomePage" pref="{{prefs.homepage}}"
+ can-tab="[[!prefs.homepage_is_newtabpage.value]]">
+ </home-url-input>
</controlled-radio-button>
<template is="dom-if" if="[[prefs.homepage.extensionId]]">
<extension-controlled-indicator

Powered by Google App Engine
This is Rietveld 408576698