MD Settings: change settings-input to home-url-input due to reduced usage.

chrome/test/data/webui/settings/appearance_page_test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {settings.AppearanceBrowserProxy}
  * @extends {settings.TestBrowserProxy}
  */
 var TestAppearanceBrowserProxy = function() {
@@ skipping 232 matching lines @@
   });
 
   test('show home button toggling', function() {
     assertFalse(!!appearancePage.$$('.list-frame'));
     appearancePage.set('prefs', {browser: {show_home_button: {value: true}}});
 
     Polymer.dom.flush();
 
     assertTrue(!!appearancePage.$$('.list-frame'));
   });
+});
+
+suite('HomeUrlInput', function() {
+  var homeUrlInput;
+
+  setup(function() {
+    appearanceBrowserProxy = new TestAppearanceBrowserProxy();
+    settings.AppearanceBrowserProxyImpl.instance_ = appearanceBrowserProxy;
+
+    appearanceBrowserProxy.reset();

[dpapad, 2017/03/31 20:38:52]

Nit: There is no need to reset() the proxy if you are always creating a new one.

[scottchen, 2017/03/31 21:02:46]

Done.

+    PolymerTest.clearBody();
+
+    homeUrlInput = document.createElement('home-url-input');
+    homeUrlInput.set(
+        'pref', {type: chrome.settingsPrivate.PrefType.URL, value: 'test'});
+
+    document.body.appendChild(homeUrlInput);
+    Polymer.dom.flush();
+  });
 
   test('home button urls', function() {
-    appearancePage.set('prefs', {
-      browser: {show_home_button: {value: true}},
-      homepage: {type: chrome.settingsPrivate.PrefType.URL, value: 'test'}
-    });
+    assertFalse(homeUrlInput.invalid);
+    assertEquals(homeUrlInput.value, 'test');
 
-    Polymer.dom.flush();
-
-    var input = appearancePage.$$('#customHomePage');
-    assertTrue(!!input);
-    assertFalse(input.invalid);
-    assertEquals(input.value, 'test');
-
-    input.value = '@@@';
+    homeUrlInput.value = '@@@';
     appearanceBrowserProxy.setValidStartupPageResponse(false);
-    input.fire('input');
+    homeUrlInput.$.input.fire('input');
 
     return appearanceBrowserProxy.whenCalled('validateStartupPage')
         .then(function() {

[dpapad, 2017/03/31 20:38:52]

Can you add an assertion that checks that the string sent to the proxy is the
right one? 

...
  .then(function(url) {
    assertEquals(homeUrlInput.value, url);
    ...

[scottchen, 2017/03/31 21:02:46]

The Promise only resolves with a boolean value, it doesn't send the original url
back.

[dpapad, 2017/03/31 21:05:08]

Need to change this line,
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/appearan...

to this.methodCalled('validateStartupPage', value);
|value| will be forwarded to the promise returned by whenCalled(). We use that
pattern in several places to check that the arguments passed to the proxy are
correct.

[scottchen, 2017/03/31 21:20:43]

Done.

           Polymer.dom.flush();
-          assertEquals(input.value, '@@@');
-          assertTrue(input.invalid);
+          assertEquals(homeUrlInput.value, '@@@');
+          assertTrue(homeUrlInput.invalid);
 
           // Should reset to default value on change event.
-          input.$$('paper-input').fire('change');
+          homeUrlInput.$.input.fire('change');
           Polymer.dom.flush();
-          assertEquals(input.value, 'test');
+          assertEquals(homeUrlInput.value, 'test');
         });
   });
-});
+});