Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2773163002: Include control clip in list of clip-related properties. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2267 matching lines...) Expand 10 before | Expand all | Expand 10 after
2278 bool LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize() const { 2278 bool LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize() const {
2279 if (hasNonCompositedScrollbars() || getSelectionState() != SelectionNone || 2279 if (hasNonCompositedScrollbars() || getSelectionState() != SelectionNone ||
2280 hasBoxDecorationBackground() || styleRef().hasBoxDecorations() || 2280 hasBoxDecorationBackground() || styleRef().hasBoxDecorations() ||
2281 styleRef().hasVisualOverflowingEffect()) 2281 styleRef().hasVisualOverflowingEffect())
2282 return false; 2282 return false;
2283 2283
2284 // If the box has clip or mask, we need issue paint invalidation to cover 2284 // If the box has clip or mask, we need issue paint invalidation to cover
2285 // the changed part of children when the box got resized. In SPv2 this is 2285 // the changed part of children when the box got resized. In SPv2 this is
2286 // handled by detecting paint property changes. 2286 // handled by detecting paint property changes.
2287 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 2287 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
2288 if (hasClipRelatedProperty() || hasControlClip() || hasMask()) 2288 if (hasClipRelatedProperty() || hasMask())
2289 return false; 2289 return false;
2290 } 2290 }
2291 2291
2292 // If the box paints into its own backing, we can assume that it's painting 2292 // If the box paints into its own backing, we can assume that it's painting
2293 // may have some effect. For example, honoring the border-radius clip on 2293 // may have some effect. For example, honoring the border-radius clip on
2294 // a composited child paints into a mask for an otherwise non-painting 2294 // a composited child paints into a mask for an otherwise non-painting
2295 // element, because children of that element will require the mask. 2295 // element, because children of that element will require the mask.
2296 if (hasLayer() && layer()->compositingState() == PaintsIntoOwnBacking) 2296 if (hasLayer() && layer()->compositingState() == PaintsIntoOwnBacking)
2297 return false; 2297 return false;
2298 2298
(...skipping 3402 matching lines...) Expand 10 before | Expand all | Expand 10 after
5701 block->adjustChildDebugRect(rect); 5701 block->adjustChildDebugRect(rect);
5702 5702
5703 return rect; 5703 return rect;
5704 } 5704 }
5705 5705
5706 bool LayoutBox::shouldClipOverflow() const { 5706 bool LayoutBox::shouldClipOverflow() const {
5707 return hasOverflowClip() || styleRef().containsPaint() || hasControlClip(); 5707 return hasOverflowClip() || styleRef().containsPaint() || hasControlClip();
5708 } 5708 }
5709 5709
5710 } // namespace blink 5710 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698