Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3431)

Unified Diff: chrome/common/extensions/api/sync_file_system.idl

Issue 277313002: Make it clear that syncFS getrequestFileSystem can fail. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/sync_file_system.idl
diff --git a/chrome/common/extensions/api/sync_file_system.idl b/chrome/common/extensions/api/sync_file_system.idl
index c1e2eebef29be9c05d799324978e041a5b011617..4ff291209f8a096e412987643cf545b2deac37d8 100644
--- a/chrome/common/extensions/api/sync_file_system.idl
+++ b/chrome/common/extensions/api/sync_file_system.idl
@@ -146,6 +146,10 @@ namespace syncFileSystem {
//
// Calling this multiple times from
// the same app will return the same handle to the same file system.
+ //
+ // Note this call can fail. For example, if the user is not signed in to
+ // Chrome or if there is no network operation. To handle these errors it is
+ // important chrome.runtime.lastError is checked in the callback.
static void requestFileSystem(GetFileSystemCallback callback);
// Sets the default conflict resolution policy
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698