Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2773073003: Revert "Added page to Observatory to display native memory allocation information." (Closed)

Created:
3 years, 9 months ago by bkonyi
Modified:
3 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Added page to Observatory to display native memory allocation information." This reverts commit f30f312b487f88ade32405bd6c9e2e943a5586d1. Revert "Fixed missing method referenced when MallocHooks is unsupported." This reverts commit a0b9c5a17809d38e8677004e9af93816aae9298d. TBR=johnmccutchan@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9ea672efc08d9317d307a3675fe4e8fcc4ecd63a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -1074 lines) Patch
M runtime/observatory/lib/elements.dart View 3 chunks +0 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 chunks +0 lines, -20 lines 0 comments Download
M runtime/observatory/lib/src/cpu_profile/cpu_profile.dart View 18 chunks +22 lines, -132 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_ref.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_ref.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart View 10 chunks +15 lines, -109 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_ref.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/uris.dart View 1 chunk +0 lines, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/native_memory_profiler.dart View 1 chunk +0 lines, -162 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/sample_profile.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/repositories/sample_profile.dart View 5 chunks +10 lines, -39 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +22 lines, -21 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D runtime/observatory/tests/service/get_native_allocation_samples_test.dart View 1 chunk +0 lines, -85 lines 0 comments Download
M runtime/vm/malloc_hooks.cc View 5 chunks +6 lines, -14 lines 0 comments Download
M runtime/vm/malloc_hooks_unsupported.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/profiler.h View 9 chunks +1 line, -61 lines 0 comments Download
M runtime/vm/profiler.cc View 5 chunks +5 lines, -15 lines 0 comments Download
M runtime/vm/profiler_service.h View 4 chunks +1 line, -19 lines 0 comments Download
M runtime/vm/profiler_service.cc View 32 chunks +114 lines, -150 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 chunk +0 lines, -211 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bkonyi
3 years, 9 months ago (2017-03-24 16:47:38 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9ea672efc08d9317d307a3675fe4e8fcc4ecd63a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698