Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: third_party/WebKit/Source/platform/heap/Heap.h

Issue 2773013002: Oilpan: isHeapObjectAlive should not return true for cross thread objects (Closed)
Patch Set: fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/Heap.h
diff --git a/third_party/WebKit/Source/platform/heap/Heap.h b/third_party/WebKit/Source/platform/heap/Heap.h
index 7246971d1fcbf46688f05ac4bf97834ca98033ab..4a15e29ad28cce179e48d3b1e241d440b4fe7677 100644
--- a/third_party/WebKit/Source/platform/heap/Heap.h
+++ b/third_party/WebKit/Source/platform/heap/Heap.h
@@ -248,9 +248,8 @@ class PLATFORM_EXPORT ThreadHeap {
// threads.
if (!ThreadState::current())
return true;
- if (&ThreadState::current()->heap() !=
- &pageFromObject(object)->arena()->getThreadState()->heap())
- return true;
+ DCHECK(&ThreadState::current()->heap() ==
sof 2017/03/28 19:50:09 How does this work for CrossThreadWeakPersistent<>
sof 2017/03/28 20:02:07 The shouldTracePersistentNode() same-heap check sh
+ &pageFromObject(object)->arena()->getThreadState()->heap());
return ObjectAliveTrait<T>::isHeapObjectAlive(object);
}
template <typename T>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698